From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/5] usb, ohci: fix ohci swap register access
Date: Tue, 16 Jul 2019 10:49:04 +0200 [thread overview]
Message-ID: <20190716084907.1568340-3-hs@denx.de> (raw)
In-Reply-To: <20190716084907.1568340-1-hs@denx.de>
commit 57faca19a82f ("drivers: USB: OHCI: allow compilation for 64-bit targets")
broke ohci support for the mpc85xx based socrates board,
as it removed volatile keyword from ohci_readl/writel.
Fix this so usb works again on socrates board.
Signed-off-by: Heiko Schocher <hs@denx.de>
---
drivers/usb/host/ohci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h
index f9f02cb09c..9b264bd92a 100644
--- a/drivers/usb/host/ohci.h
+++ b/drivers/usb/host/ohci.h
@@ -14,8 +14,8 @@
#include <asm/io.h>
#ifdef CONFIG_SYS_OHCI_SWAP_REG_ACCESS
-# define ohci_readl(a) __swap_32(readl(a))
-# define ohci_writel(v, a) writel(__swap_32(v), a)
+# define ohci_readl(a) __swap_32(in_be32((u32 *)a))
+# define ohci_writel(a, b) out_be32((u32 *)b, __swap_32(a))
#else
# define ohci_readl(a) readl(a)
# define ohci_writel(v, a) writel(v, a)
--
2.21.0
next prev parent reply other threads:[~2019-07-16 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 8:49 [U-Boot] [PATCH v1 0/5] usb, ohci-hcd: add usb ohci pci DM driver Heiko Schocher
2019-07-16 8:49 ` [U-Boot] [PATCH v1 1/5] usb, ohci-hdc: fix warning 'ohci_pci_ids' defined but not used Heiko Schocher
2019-07-16 8:49 ` Heiko Schocher [this message]
2019-07-16 8:49 ` [U-Boot] [PATCH v1 3/5] usb, ohci-hcd: set OHCI_USE_NPS if DM_PCI Heiko Schocher
2019-07-16 8:49 ` [U-Boot] [PATCH v1 4/5] usb, ohci: add warning if none on pci found Heiko Schocher
2019-07-16 8:49 ` [U-Boot] [PATCH v1 5/5] usb, ohci, pci: add DM support for PCI-based OHCI USB controller Heiko Schocher
2019-07-21 10:52 ` [U-Boot] [PATCH v1 0/5] usb, ohci-hcd: add usb ohci pci DM driver Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716084907.1568340-3-hs@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox