public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chris Webb <chris@arachsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] rockchip: make_fit_atf.py: Eliminate pyelftools dependency
Date: Tue, 16 Jul 2019 12:46:52 +0100	[thread overview]
Message-ID: <20190716114652.GA14491@arachsys.com> (raw)
In-Reply-To: <fc485691-4df1-c0a7-c60b-6cb46579fc36@rock-chips.com> <7bf9f588-3221-e196-9773-a5949b6ece67@rock-chips.com>

Hi Andy and Kever

Andy Yan <andy.yan@rock-chips.com> writes:

> One small coding style issue:
> 
> offset = e_phoff + e_phentsize * index

Thanks, will fix this.

Kever Yang <kever.yang@rock-chips.com> writes:

> Please fix the coding style comment by Andy, for other codes:
> 
> Reviewed-by: Kever Yang <Kever.yang@rock-chips.com>

Newbie contributor so can I check: is it right to add this Reviewed-by:
line to the end of the patch commit message after my Signed-off-by: when I
resend the patches as v3 with the style correction?

Many thanks,
Chris.

  reply	other threads:[~2019-07-16 11:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-14  8:45 [U-Boot] [PATCH v2 0/2] rockchip: make_fit_atf.py Eliminate pyelftools dependency Chris Webb
2019-07-14  8:46 ` [U-Boot] [PATCH v2 1/2] rockchip: make_fit_atf.py: " Chris Webb
2019-07-16  8:45   ` Andy Yan
2019-07-16 11:46     ` Chris Webb [this message]
2019-07-16 11:04   ` Kever Yang
2019-07-14  8:47 ` [U-Boot] [PATCH v2 2/2] rockchip: Remove obsolete references to pyelftools Chris Webb
2019-07-16 11:02   ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190716114652.GA14491@arachsys.com \
    --to=chris@arachsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox