From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Webb Date: Tue, 16 Jul 2019 12:46:52 +0100 Subject: [U-Boot] [PATCH v2 1/2] rockchip: make_fit_atf.py: Eliminate pyelftools dependency In-Reply-To: <7bf9f588-3221-e196-9773-a5949b6ece67@rock-chips.com> Message-ID: <20190716114652.GA14491@arachsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andy and Kever Andy Yan writes: > One small coding style issue: > > offset = e_phoff + e_phentsize * index Thanks, will fix this. Kever Yang writes: > Please fix the coding style comment by Andy, for other codes: > > Reviewed-by: Kever Yang Newbie contributor so can I check: is it right to add this Reviewed-by: line to the end of the patch commit message after my Signed-off-by: when I resend the patches as v3 with the style correction? Many thanks, Chris.