From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 13/57] ram: rk3399: Update cs0_row to use sys_reg3
Date: Tue, 16 Jul 2019 17:27:01 +0530 [thread overview]
Message-ID: <20190716115745.12585-14-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20190716115745.12585-1-jagan@amarulasolutions.com>
cs0_row can handle the pmu via sys_reg2 and sys_reg3 while
configuring the dram instead of just sys_reg2.
So, update cs0_row macro to make use of both sys_reg2,
sys_reg3.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Signed-off-by: YouMin Chen <cym@rock-chips.com>
---
arch/arm/include/asm/arch-rockchip/sdram_common.h | 8 ++++++--
drivers/ram/rockchip/sdram_rk3399.c | 4 +++-
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/arch-rockchip/sdram_common.h b/arch/arm/include/asm/arch-rockchip/sdram_common.h
index 4749233226..f74377225c 100644
--- a/arch/arm/include/asm/arch-rockchip/sdram_common.h
+++ b/arch/arm/include/asm/arch-rockchip/sdram_common.h
@@ -90,8 +90,6 @@ struct sdram_base_params {
SYS_REG_BK_SHIFT(ch))
#define SYS_REG_CS0_ROW_SHIFT(ch) (6 + (ch) * 16)
#define SYS_REG_CS0_ROW_MASK 3
-#define SYS_REG_ENC_CS0_ROW(n, ch) (((n) - 13) << \
- SYS_REG_CS0_ROW_SHIFT(ch))
#define SYS_REG_CS1_ROW_SHIFT(ch) (4 + (ch) * 16)
#define SYS_REG_CS1_ROW_MASK 3
#define SYS_REG_ENC_CS1_ROW(n, ch) (((n) - 13) << \
@@ -103,6 +101,12 @@ struct sdram_base_params {
#define SYS_REG_DBW_MASK 3
#define SYS_REG_ENC_DBW(n, ch) ((2 >> (n)) << SYS_REG_DBW_SHIFT(ch))
+#define SYS_REG_ENC_CS0_ROW(n, os_reg2, os_reg3, ch) do { \
+ (os_reg2) |= (((n) - 13) & 0x3) << (6 + 16 * (ch)); \
+ (os_reg3) |= ((((n) - 13) & 0x4) >> 2) << \
+ (5 + 2 * (ch)); \
+ } while (0)
+
/* Get sdram size decode from reg */
size_t rockchip_sdram_size(phys_addr_t reg);
diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index 2ef969c07b..70867cbd5f 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -1074,6 +1074,7 @@ static void dram_all_config(struct dram_info *dram,
const struct rk3399_sdram_params *params)
{
u32 sys_reg2 = 0;
+ u32 sys_reg3 = 0;
unsigned int channel, idx;
sys_reg2 |= SYS_REG_ENC_DDRTYPE(params->base.dramtype);
@@ -1094,10 +1095,10 @@ static void dram_all_config(struct dram_info *dram,
sys_reg2 |= SYS_REG_ENC_RANK(info->cap_info.rank, channel);
sys_reg2 |= SYS_REG_ENC_COL(info->cap_info.col, channel);
sys_reg2 |= SYS_REG_ENC_BK(info->cap_info.bk, channel);
- sys_reg2 |= SYS_REG_ENC_CS0_ROW(info->cap_info.cs0_row, channel);
sys_reg2 |= SYS_REG_ENC_CS1_ROW(info->cap_info.cs1_row, channel);
sys_reg2 |= SYS_REG_ENC_BW(info->cap_info.bw, channel);
sys_reg2 |= SYS_REG_ENC_DBW(info->cap_info.dbw, channel);
+ SYS_REG_ENC_CS0_ROW(info->cap_info.cs0_row, sys_reg2, sys_reg3, channel);
ddr_msch_regs = dram->chan[channel].msch;
noc_timing = ¶ms->ch[channel].noc_timings;
@@ -1119,6 +1120,7 @@ static void dram_all_config(struct dram_info *dram,
}
writel(sys_reg2, &dram->pmugrf->os_reg2);
+ writel(sys_reg3, &dram->pmugrf->os_reg3);
rk_clrsetreg(&dram->pmusgrf->soc_con4, 0x1f << 10,
params->base.stride << 10);
--
2.18.0.321.gffc6fa0e3
next prev parent reply other threads:[~2019-07-16 11:57 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 11:56 [U-Boot] [PATCH v3 00/57] ram: rk3399: Add LPDDR4 support Jagan Teki
2019-07-16 11:56 ` [U-Boot] [PATCH v3 01/57] ram: rk3399: Add ddrtype enc macro Jagan Teki
2019-07-16 12:57 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 02/57] ram: rk3399: Add channel number encoder macro Jagan Teki
2019-07-16 12:58 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 03/57] ram: rk3399: Add row_3_4 enc macro Jagan Teki
2019-07-16 12:58 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 04/57] ram: rk3399: Add chipinfo macro Jagan Teki
2019-07-16 12:58 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 05/57] ram: rk3399: Add rank enc macro Jagan Teki
2019-07-16 12:58 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 06/57] ram: rk3399: Add column " Jagan Teki
2019-07-16 12:59 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 07/57] ram: rk3399: Add bk " Jagan Teki
2019-07-16 13:00 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 08/57] ram: rk3399: Add dbw " Jagan Teki
2019-07-16 13:00 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 09/57] ram: rk3399: Add cs0_rw macro Jagan Teki
2019-07-16 13:00 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 10/57] ram: rk3399: Add cs1_rw macro Jagan Teki
2019-07-16 13:03 ` Kever Yang
2019-07-16 11:56 ` [U-Boot] [PATCH v3 11/57] ram: rk3399: Add bw enc macro Jagan Teki
2019-07-16 13:03 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 12/57] ram: rk3399: Rename sys_reg with sys_reg2 Jagan Teki
2019-07-16 13:03 ` Kever Yang
2019-07-16 11:57 ` Jagan Teki [this message]
2019-07-16 13:03 ` [U-Boot] [PATCH v3 13/57] ram: rk3399: Update cs0_row to use sys_reg3 Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 14/57] ram: rk3399: Update cs1_row " Jagan Teki
2019-07-16 13:03 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 15/57] ram: rk3399: Add cs1_col enc macro Jagan Teki
2019-07-16 13:02 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 16/57] ram: rk3399: Add ddr version " Jagan Teki
2019-07-16 13:02 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 17/57] ram: rk3399: Add ddrtimingC0 Jagan Teki
2019-07-16 13:02 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 18/57] ram: rk3399: Add DdrMode Jagan Teki
2019-07-16 13:02 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 19/57] ram: rk3399: Configure phy IO in ds odt Jagan Teki
2019-07-16 13:04 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 20/57] ram: rockchip: Kconfig: Add RK3399 LPDDR4 entry Jagan Teki
2019-07-16 13:10 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 21/57] ram: rk3399: Add lpddr4 rank mask for ca training Jagan Teki
2019-07-16 13:11 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 22/57] ram: rk3399: Add lpddr4 rank mask for wdql training Jagan Teki
2019-07-16 13:11 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 23/57] ram: rk3399: Move mode_sel assignment Jagan Teki
2019-07-16 13:12 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 24/57] ram: rk3399: Don't wait for PLL lock in lpddr4 Jagan Teki
2019-07-16 13:12 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 25/57] ram: rk3399: Avoid two channel ZQ Cal Start at the same time Jagan Teki
2019-07-16 13:12 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 26/57] ram: rk3399: Configure PHY_898, PHY_919 for lpddr4 Jagan Teki
2019-07-16 13:12 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 27/57] ram: rk3399: Configure BOOSTP_EN, BOOSTN_EN " Jagan Teki
2019-07-16 13:12 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 28/57] ram: rk3399: Configure SLEWP_EN, SLEWN_EN " Jagan Teki
2019-07-16 13:13 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 29/57] ram: rk3399: Configure PHY RX_CM_INPUT " Jagan Teki
2019-07-16 13:13 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 30/57] ram: rk3399: Map chipselect " Jagan Teki
2019-07-16 13:13 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 31/57] ram: rk3399: Configure tsel write ca " Jagan Teki
2019-07-16 13:14 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 32/57] ram: rk3399: Don't disable dfi dram clk for lpddr4, rank 1 Jagan Teki
2019-07-16 13:14 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 33/57] ram: rk3399: Add IO settings Jagan Teki
2019-07-16 13:14 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 34/57] ram: sdram: Configure lpddr4 tsel rd, wr based on " Jagan Teki
2019-07-16 13:15 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 35/57] ram: rk3399: Add tsel control clock drive Jagan Teki
2019-07-16 13:15 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 36/57] ram: rk3399: Configure soc odt support Jagan Teki
2019-07-16 13:15 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 37/57] ram: rk3399: Get lpddr4 tsel_rd_en from io settings Jagan Teki
2019-07-16 13:15 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 38/57] ram: rk3399: Update lpddr4 vref based on " Jagan Teki
2019-07-16 13:16 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 39/57] ram: rk3399: Update lpddr4 mode_sel " Jagan Teki
2019-07-16 13:16 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 40/57] ram: rk3399: Update lpddr4 vref_mode_ac Jagan Teki
2019-07-16 13:17 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 41/57] ram: rk3399: Simplify data training first argument Jagan Teki
2019-07-16 13:17 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 42/57] ram: rk3399: Handle data training via ops Jagan Teki
2019-07-16 13:18 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 43/57] ram: rk3399: Add LPPDR4 mr detection Jagan Teki
2019-07-16 13:18 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 44/57] arm: include: rockchip: Add rk3399 pmu file Jagan Teki
2019-07-16 13:18 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 45/57] rockchip: rk3399: syscon: Add pmu support Jagan Teki
2019-07-16 13:19 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 46/57] rockchip: dts: rk3399: Add u-boot, dm-pre-reloc for pmu Jagan Teki
2019-07-16 13:19 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 47/57] clk: rockchip: rk3399: Set 50MHz ddr clock Jagan Teki
2019-07-16 13:19 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 48/57] clk: rockchip: rk3399: Set 400MHz " Jagan Teki
2019-07-16 13:19 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 49/57] ram: rk3399: Add LPPDDR4-400 timings inc Jagan Teki
2019-07-16 13:20 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 50/57] ram: rk3399: Add LPPDDR4-800 " Jagan Teki
2019-07-16 13:20 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 51/57] ram: rk3399: Add set_rate sdram rk3399 ops Jagan Teki
2019-07-16 13:20 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 52/57] ram: rk3399: Add lpddr4 set rate support Jagan Teki
2019-07-16 13:21 ` Kever Yang
2019-07-20 3:13 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 53/57] configs: rockpro64: Enable LPDDR4 support Jagan Teki
2019-07-16 13:21 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 54/57] configs: rock-pi-4: " Jagan Teki
2019-07-16 13:21 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 55/57] rockchip: dts: rk3399: Add LPDDR4-100 timings Jagan Teki
2019-07-16 13:21 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 56/57] rockchip: dts: rk3399: rockpro64: Use LPDDR4-100 dtsi Jagan Teki
2019-07-16 13:22 ` Kever Yang
2019-07-16 11:57 ` [U-Boot] [PATCH v3 57/57] rockchip: dts: rk3399: rock-pi-4: " Jagan Teki
2019-07-16 13:22 ` Kever Yang
2019-07-16 13:10 ` [U-Boot] [PATCH v3 00/57] ram: rk3399: Add LPDDR4 support Kever Yang
2019-10-06 1:05 ` Qu Wenruo
2019-10-06 1:28 ` Manivannan Sadhasivam
2019-10-06 1:30 ` Qu Wenruo
2019-10-08 0:31 ` Kever Yang
2019-10-12 10:37 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716115745.12585-14-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox