[U-Boot] 答复: 答复: [PATCH 0/4] Make some changes to SDP

Sherry Sun
2019-08-08T09:38:12Z

Hi Angus,

Sorry for the late reply.

> -----邮件原件-----
> 发件人: Angus Ainslie <angus@akkea.ca>
> 发送时间: 2019年8月2日 10:30
> 收件人: Peng Fan <peng.fan@nxp.com>
> 抄送: Sherry Sun <sherry.sun@nxp.com>; sbabic at denx.de;
> festevam at gmail.com; lukma at denx.de; marex at denx.de;
> u-boot at lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com>
> 主题: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
>
> Hi Peng,
>
> On 2019-08-01 18:01, Peng Fan wrote:
> > Angus,
> >
> >> Subject: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
> >>
> >> Hi Sherry,
> >>
> >> On 2019-07-31 19:56, Sherry Sun wrote:
> >> > Hi Angus
> >> >
> >> >>
> >> >> Hi Sherry,
> >> >>
> >> >> On 2019-07-17 18:40, sherry sun wrote:
> >> >> > From: Sherry Sun <sherry.sun@nxp.com>
> >> >> >
> >> >> > This patchset adds:
> >> >> > 1. Add usb_gadget_initialize() and usb_gadget_release() to
> >> >> > initialize and release UDC during sdp download.
> >> >> > 2. Add high speed endpoint descriptor for sdp.
> >> >> > 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp
> >> >> > load address while SDP_WRITE and SDP_JUMP command addr is zero.
> >> >> >
> >> >> > Sherry Sun (4):
> >> >> > imx: spl: Change USB boot device type
> >> >> > SDP: use CONFIG_SDP_LOADADDR as default load address
> >> >> > SDP: fix wrong usb request size and add high speed endpoint
> >> >> > descriptor
> >> >> > SDP: Call usb_gadget_initialize and usb_gadget_release to
> >> >> > support UDC
> >> >>
> >> >> These changes look like like they target SDP on imx8. For imx8mq
> >> >> is this all that is required to get SDP working with uuu or are
> >> >> there additional changes required ?
> >> >>
> >> >
> >> > The changes in patch 1/4 are target on both imx8 and imx8m.
> >> > The rest three patches are target on all boards which used SDP.
> >> > So for imx8mq, if your usb gadget driver is ready ,these changes
> >> > are enough to get SDP working with UUU.
> >> >
> >>
> >> I'm trying to use SDP on the imx8mq-evk but it doesn't look like it's
> >> enabled there. Do you have patches to enable SDP on the imx8mq-evk ,
> >> even if they aren't ready to go upstream ?
> >
> > You could try downstream code,
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
> >
> ce.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2F&amp;data=02%7C01
> %7Cs
> >
> herry.sun%40nxp.com%7C6d63289fbb104168bce308d716f157c4%7C686ea1
> d3bc2b4
> >
> c6fa92cd99c5c301635%7C0%7C0%7C637003098143081621&amp;sdata=beh
> 08%2Fv3f
> > s8ZZPP29F1iVMfo3uNTWGf91SYYyak2GVU%3D&amp;reserved=0
> > branch: imx_v2019.04_4.19.35_1.0.0
> >
>
> I already have SDP working with the vendor u-boot. I'm trying to switch to
> mainline u-boot so I'm looking for mainline patches.
>

May I ask, is your usb gadget driver is working? Such as you can use it for fastboot or ums.

Best regards
Sherry sun

> Thanks
> Angus
>
> > Regards,
> > Peng.
> >
> >>
> >> Thanks
> >> Angus
> >>
> >> > Best regards
> >> > Sherry sun
> >> >
> >> >> Thanks
> >> >> Angus
> >> >>
> >> >> >
> >> >> > arch/arm/mach-imx/spl.c | 2 +-
> >> >> > common/spl/spl_sdp.c | 4 ++++
> >> >> > drivers/usb/gadget/Kconfig | 4 ++++
> >> >> > drivers/usb/gadget/f_sdp.c |
> >> >> > 39
> >> >> > +++++++++++++++++++++++++++++++++-----
> >> >> > 4 files changed, 43 insertions(+), 6 deletions(-)