[U-Boot] [PATCH 1/4] imx: spl: Change USB boot device type

Peng Fan
2019-07-18T07:47:53Z

> Subject: Re: [PATCH 1/4] imx: spl: Change USB boot device type
>
> On Thu, 18 Jul 2019 07:38:10 +0000
> Peng Fan <peng.fan@nxp.com> wrote:
>
> > Hi Lukasz,
> >
> > > Subject: Re: [PATCH 1/4] imx: spl: Change USB boot device type
> > >
> > > Hi Sherry,
> > >
> > > > From: Sherry Sun <sherry.sun@nxp.com>
> > > >
> > > > The SPL SDP is configured as BOOT_DEVICE_BOARD, so when booting
> > > > from USB, change its type to BOOT_DEVICE_BOARD, so we can use SDP.
> > > >
> > > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > > > Signed-off-by: Ye Li <ye.li@nxp.com>
> > > > ---
> > > > arch/arm/mach-imx/spl.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c
> > > > index 9f1e0f6a72..2355019243 100644
> > > > --- a/arch/arm/mach-imx/spl.c
> > > > +++ b/arch/arm/mach-imx/spl.c
> > > > @@ -156,7 +156,7 @@ u32 spl_boot_device(void)
> > > > case SPI_NOR_BOOT:
> > > > return BOOT_DEVICE_SPI;
> > > > case USB_BOOT:
> > > > - return BOOT_DEVICE_USB;
> > > > + return BOOT_DEVICE_BOARD;
> > >
> > > Why this change is required? What is the problem you are trying to
> > > solve here? (And it is always welcome if one write the detailed
> > > description of the problem in the commit message).
> >
> > It is spl sdp need it.
> > SPL_LOAD_IMAGE_METHOD("USB SDP", 0, BOOT_DEVICE_BOARD,
> > spl_sdp_load_image);
>
> My point is why this error was not apparent earlier (or when I was using the
> uuu with newest u-boot)?

The patch changes the i.MX7/8/8M spl_boot_device,
i.MX7 already have BOARD support. i.MX8/8M has not been verified
SDP before, so this patch is to fix for i.MX8/8M SDP.

Regards,
Peng.

>
> I'm just curious why let's say "average" uuu/SDP user did not encountered this
> problem (as I had also to recover SPL on my i.MX6 board).
>
> >
> > Regards,
> > Peng.
> >
> > >
> > > I've been using recently SDP (with uuu on imx6q) and I did not
> > > experience any issues.
> > >
> > > > default:
> > > > return BOOT_DEVICE_NONE;
> > > > }
> > >
> > >
> > >
> > >
> > > Best regards,
> > >
> > > Lukasz Majewski
> > >
> > > --
> > >
> > > DENX Software Engineering GmbH, Managing Director: Wolfgang
> > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > > lukma at denx.de
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma at denx.de