From: Vladimir Oltean <olteanv@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/9] net: tsec: Make errors visible
Date: Fri, 19 Jul 2019 00:29:56 +0300 [thread overview]
Message-ID: <20190718213001.24815-5-olteanv@gmail.com> (raw)
In-Reply-To: <20190718213001.24815-1-olteanv@gmail.com>
This replaces debug() calls with printf() so that it is immediately
obvious from the console that something is wrong.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:
None.
Changes from v1:
None.
drivers/net/tsec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index ce19ff9228fd..1e20fe4cd246 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -268,7 +268,7 @@ static int tsec_send(struct udevice *dev, void *packet, int length)
in_be16(&priv->txbd[priv->tx_idx].status) & TXBD_READY;
i++) {
if (i >= TOUT_LOOP) {
- debug("%s: tsec: tx buffers full\n", dev->name);
+ printf("%s: tsec: tx buffers full\n", dev->name);
return result;
}
}
@@ -287,7 +287,7 @@ static int tsec_send(struct udevice *dev, void *packet, int length)
in_be16(&priv->txbd[priv->tx_idx].status) & TXBD_READY;
i++) {
if (i >= TOUT_LOOP) {
- debug("%s: tsec: tx error\n", dev->name);
+ printf("%s: tsec: tx error\n", dev->name);
return result;
}
}
@@ -809,7 +809,7 @@ int tsec_probe(struct udevice *dev)
if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
&phandle_args)) {
- debug("phy-handle does not exist under tsec %s\n", dev->name);
+ printf("phy-handle does not exist under tsec %s\n", dev->name);
return -ENOENT;
} else {
int reg = ofnode_read_u32_default(phandle_args.node, "reg", 0);
@@ -838,7 +838,7 @@ int tsec_probe(struct udevice *dev)
if (phy_mode)
pdata->phy_interface = phy_get_interface_by_name(phy_mode);
if (pdata->phy_interface == -1) {
- debug("Invalid PHY interface '%s'\n", phy_mode);
+ printf("Invalid PHY interface '%s'\n", phy_mode);
return -EINVAL;
}
priv->interface = pdata->phy_interface;
--
2.17.1
next prev parent reply other threads:[~2019-07-18 21:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
2019-07-18 21:29 ` [U-Boot] [PATCH v3 1/9] net: tsec: Refactor the readout of the tbi-handle property Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH Vladimir Oltean
2019-07-23 6:23 ` Bin Meng
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 3/9] net: tsec: Reverse Christmas tree notation Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` Vladimir Oltean [this message]
2019-07-25 18:42 ` [U-Boot] net: tsec: Make errors visible Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 5/9] net: tsec: Common handling of MAC station address for DM_ETH Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux Vladimir Oltean
2019-07-23 3:30 ` Joe Hershberger
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver Vladimir Oltean
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:30 ` [U-Boot] [PATCH v3 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot Vladimir Oltean
2019-07-23 3:31 ` Joe Hershberger
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-18 21:30 ` [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
2019-07-23 3:35 ` Joe Hershberger
2019-07-23 6:25 ` Bin Meng
2019-07-25 18:42 ` [U-Boot] " Joe Hershberger
2019-07-25 20:30 ` Vladimir Oltean
2019-07-23 0:15 ` [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Joe Hershberger
2019-07-23 6:07 ` Vladimir Oltean
2019-07-23 7:37 ` Joe Hershberger
2019-07-24 15:37 ` Vladimir Oltean
2019-07-24 18:56 ` Joe Hershberger
2019-07-24 20:54 ` Vladimir Oltean
2019-08-14 9:37 ` Prabhakar Kushwaha
2019-08-14 9:52 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718213001.24815-5-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox