public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux
Date: Fri, 19 Jul 2019 00:29:58 +0300	[thread overview]
Message-ID: <20190718213001.24815-7-olteanv@gmail.com> (raw)
In-Reply-To: <20190718213001.24815-1-olteanv@gmail.com>

In the case of the tsec network driver, so far there has been no
mainline user of DM_ETH where the DT bindings get used.

In the case of the mdio bus, it looks like the "fsl,tsec-mdio" string
was made up for the documentation, but there is no mainline code that
parses the "compatible" property anyway.

In both cases, there are no DT blobs that contain the old strings.

So change the documentation to "fsl,etsec2" for the Ethernet ports and
"fsl,etsec2-mdio" for the MDIO buses, which are strings that Linux also
uses, at least for LS1021A.  More compatible strings can be added once
other (PowerPC) SoCs are migrated to DM_ETH.

The current ls1021a.dtsi doesn't match what was documented for the MDIO
buses anyway (the "compatible" is "gianfar" currently). This will be
fixed in the next patch.

Fixes: 69a00875e3db ("doc: dt-bindings: Describe Freescale TSEC ethernet controller")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v2:

None.

Changes from v1:

Patch is new.

 doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 ++--
 drivers/net/tsec.c                            | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/device-tree-bindings/net/fsl-tsec-phy.txt b/doc/device-tree-bindings/net/fsl-tsec-phy.txt
index c5bf48c3cb51..59989e3b09d6 100644
--- a/doc/device-tree-bindings/net/fsl-tsec-phy.txt
+++ b/doc/device-tree-bindings/net/fsl-tsec-phy.txt
@@ -28,13 +28,13 @@ device that exists on this bus, a PHY node should be created.
 
 Required properties:
   - compatible : Should define the compatible device type for the
-    mdio. Currently supported string/device is "fsl,tsec-mdio".
+    mdio. Currently supported string/device is "fsl,etsec2-mdio".
   - reg : Offset and length of the register set for the device
 
 Example:
 
 	mdio at 24520 {
-		compatible = "fsl,tsec-mdio";
+		compatible = "fsl,etsec2-mdio";
 		reg = <0x24520 0x20>;
 
 		ethernet-phy at 0 {
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index f6278817330d..f85cdcb97ebf 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -880,7 +880,7 @@ static const struct eth_ops tsec_ops = {
 };
 
 static const struct udevice_id tsec_ids[] = {
-	{ .compatible = "fsl,tsec" },
+	{ .compatible = "fsl,etsec2" },
 	{ }
 };
 
-- 
2.17.1

  parent reply	other threads:[~2019-07-18 21:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 21:29 [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Vladimir Oltean
2019-07-18 21:29 ` [U-Boot] [PATCH v3 1/9] net: tsec: Refactor the readout of the tbi-handle property Vladimir Oltean
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH Vladimir Oltean
2019-07-23  6:23   ` Bin Meng
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 3/9] net: tsec: Reverse Christmas tree notation Vladimir Oltean
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 4/9] net: tsec: Make errors visible Vladimir Oltean
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 5/9] net: tsec: Common handling of MAC station address for DM_ETH Vladimir Oltean
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` Vladimir Oltean [this message]
2019-07-23  3:30   ` [U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux Joe Hershberger
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:29 ` [U-Boot] [PATCH v3 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver Vladimir Oltean
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:30 ` [U-Boot] [PATCH v3 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot Vladimir Oltean
2019-07-23  3:31   ` Joe Hershberger
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-18 21:30 ` [U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
2019-07-23  3:35   ` Joe Hershberger
2019-07-23  6:25   ` Bin Meng
2019-07-25 18:42   ` [U-Boot] " Joe Hershberger
2019-07-25 20:30     ` Vladimir Oltean
2019-07-23  0:15 ` [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board Joe Hershberger
2019-07-23  6:07   ` Vladimir Oltean
2019-07-23  7:37     ` Joe Hershberger
2019-07-24 15:37       ` Vladimir Oltean
2019-07-24 18:56         ` Joe Hershberger
2019-07-24 20:54           ` Vladimir Oltean
2019-08-14  9:37           ` Prabhakar Kushwaha
2019-08-14  9:52             ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718213001.24815-7-olteanv@gmail.com \
    --to=olteanv@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox