From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Fri, 19 Jul 2019 10:41:06 +0200
Subject: [U-Boot] [RFC,
	PATCH v4 09/16] hashtable: extend hdelete_ext for autosave
In-Reply-To: <20190717082525.891-10-takahiro.akashi@linaro.org>
References: <20190717082525.891-1-takahiro.akashi@linaro.org>
 <20190717082525.891-10-takahiro.akashi@linaro.org>
Message-ID: <20190719084106.24897240049@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Takahiro,

In message <20190717082525.891-10-takahiro.akashi@linaro.org> you wrote:
> With this patch, an extended interface of hdelete_ext() will return
> variable's attribute. The feature will be used in a successive patch
> to determine if the context should be 'autosaved' or not even in case
> of deletion.

Why would this be added to the hdelete() code?  

hdelete() is used to DELETE entries from the hash table.  Something
that has been deleted does not have any attributes any more.

This looks all wrong to me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain fried - Core dumped