From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 05/12] armV7R: K3: am654: Allow using SPL BSS pre-relocation
Date: Sat, 20 Jul 2019 11:51:38 -0400 [thread overview]
Message-ID: <20190720155138.GY20116@bill-the-cat> (raw)
In-Reply-To: <CAAh8qswxE8d+ZYvG=TXW8a7CctNU-Sy-bncs552eDEWiMsO1AA@mail.gmail.com>
On Fri, Jul 19, 2019 at 07:29:37AM +0200, Simon Goldschmidt wrote:
> On Fri, Jul 19, 2019 at 2:29 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Jun 04, 2019 at 05:55:48PM -0500, Andreas Dannenberg wrote:
> >
> > > In order to be able to use more advanced driver functionality which often
> > > relies on having BSS initialized during early boot prior to relocation
> > > several things need to be in place:
> > >
> > > 1) Memory needs to be available for BSS to use. For this, we locate BSS
> > > at the top of the MCU SRAM area, with the stack starting right below
> > > it,
> > > 2) We need to move the initialization of BSS prior to entering
> > > board_init_f(). We will do this with a separate commit by turning on
> > > the respective CONFIG option.
> > >
> > > In this commit we also clean up the assignment of the initial SP address
> > > as part of the refactoring, taking into account the pre-decrement post-
> > > increment nature in which the SP is used on ARM.
> > >
> > > Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> >
> > Applied to u-boot/master, thanks!
>
> Wait, why has this been merged? Unfortunately, I haven't followed this series,
> but in a discussion about a similar patch I sent [1], using BSS from
> board_init_f
> was turned down. And Simon Glass rather convinced me that this is the current
> API U-Boot has (and is documented in README).
>
> So either we must change this API and its documentation (and I would expect the
> author of this patch to combine the README change with the code change), or this
> patch would have to be rejected.
>
> Again, I'm sorry I only see this now. In thought to remember a
> discussion in this
> thread, but I clearly remember that wrong...
>
> [1] https://patchwork.ozlabs.org/patch/1057237/
And I had missed that other thread. Lokesh, since I think Andreas is
out currently can you expand a little on what we can/can't do on this
platform? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190720/ebeb479b/attachment.sig>
next prev parent reply other threads:[~2019-07-20 15:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 22:55 [U-Boot] [PATCH v2 00/12] System Firmware Loader for TI K3 family SoCs Andreas Dannenberg
2019-06-04 22:55 ` [U-Boot] [PATCH v2 01/12] mmc: am654_sdhci: Allow driver to probe without PDs specified Andreas Dannenberg
2019-07-19 0:00 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 02/12] spl: Allow performing BSS init early before board_init_f() Andreas Dannenberg
2019-07-19 0:00 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 03/12] spl: Make image loader infrastructure more universal Andreas Dannenberg
2019-07-19 0:00 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 04/12] arm: K3: Introduce System Firmware loader framework Andreas Dannenberg
2019-07-19 0:00 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 05/12] armV7R: K3: am654: Allow using SPL BSS pre-relocation Andreas Dannenberg
2019-07-19 0:00 ` Tom Rini
2019-07-19 5:29 ` Simon Goldschmidt
2019-07-20 15:51 ` Tom Rini [this message]
2019-07-25 4:35 ` Lokesh Vutla
2019-07-25 7:01 ` Simon Goldschmidt
2019-07-25 8:22 ` Lokesh Vutla
2019-07-25 9:52 ` Simon Goldschmidt
2019-08-07 21:23 ` Andreas Dannenberg
2019-08-08 7:29 ` Simon Goldschmidt
2019-08-08 18:29 ` Andreas Dannenberg
2019-08-08 19:01 ` Simon Goldschmidt
2019-08-08 19:43 ` Andreas Dannenberg
2019-08-08 20:01 ` Simon Goldschmidt
2019-08-13 20:38 ` Simon Goldschmidt
2019-08-13 21:06 ` Andreas Dannenberg
2019-06-04 22:55 ` [U-Boot] [PATCH v2 06/12] armv7R: K3: am654: Use full malloc implementation in SPL Andreas Dannenberg
2019-07-19 0:00 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 07/12] armV7R: K3: am654: Load SYSFW binary and config from boot media Andreas Dannenberg
2019-07-19 0:00 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 08/12] configs: am65x_evm_r5: All sysfw to be loaded via MMC Andreas Dannenberg
2019-07-19 0:01 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 09/12] configs: am65x_hs_evm_r5: " Andreas Dannenberg
2019-07-19 0:01 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 10/12] configs: am65x_evm: Add Support for eMMC boot Andreas Dannenberg
2019-07-19 0:01 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 11/12] configs: am65x_hs_evm: " Andreas Dannenberg
2019-07-19 0:01 ` Tom Rini
2019-06-04 22:55 ` [U-Boot] [PATCH v2 12/12] am65x: README: Add eMMC layout and flash instructions Andreas Dannenberg
2019-07-19 0:01 ` Tom Rini
2019-06-05 6:22 ` [U-Boot] [PATCH v2 00/12] System Firmware Loader for TI K3 family SoCs Lokesh Vutla
2019-06-05 15:15 ` Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720155138.GY20116@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox