From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 23 Jul 2019 17:05:03 +0200 Subject: [U-Boot] [PATCH v2] rtc: ds3232/ds3231: Add support to generate 32KHz output for driver module In-Reply-To: <20190723095745.37138-1-chuanhua.han@nxp.com> References: <20190723095745.37138-1-chuanhua.han@nxp.com> Message-ID: <20190723150503.EB2FC24003E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Chuanhua Han, In message <20190723095745.37138-1-chuanhua.han@nxp.com> you wrote: > This patch add an implementation of the rtc_enable_32khz_output() that > uses the driver model i2c APIs. > > Signed-off-by: Chuanhua Han > --- > Change in v2: > - Add RTC_ENABLE_32KHZ_OUTPUT option so this code compiles only > in that cases where it is really useful. So when exactly is it useful? If I understand correctly, there are no users of this code in mainline. Should the patch then not be part of a patch series that adds such users? Adding potentially "useful" code just on speculation is not nice maintenance-wise. I recommend to withdraw this patch and submit it together with some real consumer of this feature. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "The question of whether a computer can think is no more interesting than the question of whether a submarine can swim" - Edsgar W. Dijkstra