From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices
Date: Fri, 26 Jul 2019 16:48:26 +0200 [thread overview]
Message-ID: <20190726164826.04818ae6@crub> (raw)
In-Reply-To: <CANr=Z=a=z627C1PwGW2Ro5vZ6zJ1B==dovivX+H6LbL=2gebKA@mail.gmail.com>
On Tue, 23 Jul 2019 04:07:04 +0000
Joe Hershberger joe.hershberger at ni.com wrote:
> > > static int mv88e61xx_phy_wait(struct phy_device *phydev)
> > > {
> > > + struct mv88e61xx_phy_priv *priv = phydev->priv;
> > > int val;
> > > u32 timeout = 100;
> > >
> > > do {
> > > - val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_2,
> > > + val = mv88e61xx_reg_read(phydev, priv->global2,
> >
> > Probably just use phydev->priv->global2 instead of the local variable.
No, I'll stick with local variable. priv is void*, we will get
+drivers/net/phy/mv88e61xx.c:338:48: error: dereferencing 'void *' pointer [-Werror]
+ val = mv88e61xx_reg_read(phydev, phydev->priv->global2,
--
Anatolij
next prev parent reply other threads:[~2019-07-26 14:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 23:22 [U-Boot] [PATCH v2 0/6] Extend mv88e61xx driver to support 88E6071 Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices Anatolij Gustschin
2019-07-23 4:00 ` Joe Hershberger
2019-07-23 4:07 ` Joe Hershberger
2019-07-26 14:48 ` Anatolij Gustschin [this message]
2019-07-26 18:51 ` Joe Hershberger
2019-07-25 21:40 ` Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 2/6] net: phy: mv88e61xx: add CPU port parameter init for 88E6071 Anatolij Gustschin
2019-07-23 4:05 ` Joe Hershberger
2019-07-25 21:40 ` Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 3/6] net: phy: mv88E61xx: fix ENERGY_DET init for mv88E6071 Anatolij Gustschin
2019-07-23 4:11 ` Joe Hershberger
2019-07-09 23:22 ` [U-Boot] [PATCH v2 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support Anatolij Gustschin
2019-07-23 4:26 ` Joe Hershberger
2019-07-25 21:41 ` Anatolij Gustschin
2019-07-29 23:18 ` Joe Hershberger
2019-09-03 22:00 ` Joe Hershberger
2019-10-26 23:15 ` Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 5/6] net: phy: mv88e61xx: register phy_driver struct for 88E6071 Anatolij Gustschin
2019-07-23 4:29 ` Joe Hershberger
2019-07-25 21:41 ` Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 6/6] net: phy: fix switch vendor name Anatolij Gustschin
2019-07-23 4:29 ` Joe Hershberger
2019-07-10 9:04 ` [U-Boot] [PATCH v2 0/6] Extend mv88e61xx driver to support 88E6071 Chris Packham
2019-07-10 9:14 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726164826.04818ae6@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox