From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] video: dw_hdmi: Add support for ddc-i2c-bus property
Date: Fri, 26 Jul 2019 21:49:49 +0200 [thread overview]
Message-ID: <20190726214949.7bd955a1@crub> (raw)
In-Reply-To: <20190717193552.7080-1-me@jns.io>
On Wed, 17 Jul 2019 19:35:52 +0000
Niklas Schulze me at jns.io wrote:
...
> @@ -812,6 +813,15 @@ static int hdmi_read_edid(struct dw_hdmi *hdmi, int block, u8 *buff)
> u32 trytime = 5;
> u32 n;
>
> + struct udevice *chip;
> + if (hdmi->ddc_bus) {
here, please use something like:
if (CONFIG_IS_ENABLED(DM_I2C) && hdmi->ddc_bus) {
struct udevice *chip;
there are boards that do not enable CONFIG_DM_I2C yet, and we will
see build breakage in such cases:
drivers/built-in.o: In function `hdmi_read_edid':
drivers/video/meson/../dw_hdmi.c:818: undefined reference to `i2c_get_chip'
drivers/video/meson/../dw_hdmi.c:822: undefined reference to `dm_i2c_read'
--
Anatolij
next prev parent reply other threads:[~2019-07-26 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 19:35 [U-Boot] [PATCH 1/1] video: dw_hdmi: Add support for ddc-i2c-bus property Niklas Schulze
2019-07-26 19:49 ` Anatolij Gustschin [this message]
2019-07-27 12:07 ` [U-Boot] [PATCH v2 " Niklas Schulze
2019-07-29 9:43 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726214949.7bd955a1@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox