[U-Boot] [RESEND PATCH v2 01/13] davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs

Adam Ford
2019-07-29T16:24:27Z

On Mon, Jul 29, 2019 at 11:14 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Jul 29, 2019 at 08:57:58AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > This option is no longer used on any davinci board but still selected
> > in defconfigs which causes the following warning:
> >
> > ===================== WARNING ======================
> > This board uses CONFIG_DM_I2C_COMPAT. Please remove
> > (possibly in a subsequent patch in your series)
> > before sending patches to the mailing list.
> > ====================================================
> >
> > Remove all references to CONFIG_DM_I2C_COMPAT from davinci.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > Acked-by: Heiko Schocher <hs@denx.de>
> > ---
> > configs/da850_am18xxevm_defconfig | 1 -
> > configs/omapl138_lcdk_defconfig | 1 -
> > include/configs/am3517_evm.h | 1 -
> > include/configs/omapl138_lcdk.h | 8 --------
> > 4 files changed, 11 deletions(-)
>
> This breaks da850_am18xxevm as dvevm_read_mac_address() in
> arch/arm/mach-davinci/misc.c has not been updated for the i2c case. I
> suspect board/atmel/common/mac_eeprom.c::at91_set_ethaddr() could be
> adapted easily enough and if you don't have a chance to do so, I'll take
> a pass at that.

I submitted a patch to remove da850_am18xxevm since it's been orphaned
for a while, and I don't have the hardware to support it as that
variation wasn't a board made by Logic PD. I would argue that we
apply the patch to remove the da850_am18xxevm, then we can apply his
patches to remove CONFIG_DM_I2C_COMPAT.

adam
>
> --
> Tom