[U-Boot] [PATCH 1/1] Dockerfile: add python3-sphinx

[U-Boot] [PATCH 1/1] Dockerfile: add python3-sphinx

[Heinrich Schuchardt]

python3-sphinx is needed to build the htmldocs target.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
This patch relates to
https://gitlab.denx.de/u-boot/gitlab-ci-runner
---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Dockerfile b/Dockerfile
index 73c1b8b..e8468ce 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \
 	python-pip \
 	python-pytest \
 	python-virtualenv \
+	python3-sphinx \
 	rpm2cpio \
 	sloccount \
 	sparse \
--
2.20.1

[U-Boot] [PATCH 1/1] Dockerfile: add python3-sphinx

[Bin Meng]

On Fri, Jul 26, 2019 at 4:34 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> python3-sphinx is needed to build the htmldocs target.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> This patch relates to
> https://gitlab.denx.de/u-boot/gitlab-ci-runner
> ---
>  Dockerfile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Dockerfile b/Dockerfile
> index 73c1b8b..e8468ce 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \
>         python-pip \
>         python-pytest \
>         python-virtualenv \
> +       python3-sphinx \

Given other packages are using python2, should we use python-sphinx too?

>         rpm2cpio \
>         sloccount \
>         sparse \
> --

Regards,
Bin

[U-Boot] [PATCH 1/1] Dockerfile: add python3-sphinx

[Tom Rini]

On Sat, Jul 27, 2019 at 09:08:26PM +0800, Bin Meng wrote:
> On Fri, Jul 26, 2019 at 4:34 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > python3-sphinx is needed to build the htmldocs target.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> > This patch relates to
> > https://gitlab.denx.de/u-boot/gitlab-ci-runner
> > ---
> >  Dockerfile | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Dockerfile b/Dockerfile
> > index 73c1b8b..e8468ce 100644
> > --- a/Dockerfile
> > +++ b/Dockerfile
> > @@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \
> >         python-pip \
> >         python-pytest \
> >         python-virtualenv \
> > +       python3-sphinx \
> 
> Given other packages are using python2, should we use python-sphinx too?

We should be forward-looking towards using python3 for everything as we
_really_ do need to do that, so I'm fine with this being python3.

A good follow-up test would be to see what happens if we push as much as
possible to being python3.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190727/35f0b1ff/attachment.sig>

[U-Boot] [PATCH 1/1] Dockerfile: add python3-sphinx

[Bin Meng]

On Sat, Jul 27, 2019 at 9:33 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Sat, Jul 27, 2019 at 09:08:26PM +0800, Bin Meng wrote:
> > On Fri, Jul 26, 2019 at 4:34 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> > >
> > > python3-sphinx is needed to build the htmldocs target.
> > >
> > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > > ---
> > > This patch relates to
> > > https://gitlab.denx.de/u-boot/gitlab-ci-runner
> > > ---
> > >  Dockerfile | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Dockerfile b/Dockerfile
> > > index 73c1b8b..e8468ce 100644
> > > --- a/Dockerfile
> > > +++ b/Dockerfile
> > > @@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \
> > >         python-pip \
> > >         python-pytest \
> > >         python-virtualenv \
> > > +       python3-sphinx \
> >
> > Given other packages are using python2, should we use python-sphinx too?
>
> We should be forward-looking towards using python3 for everything as we
> _really_ do need to do that, so I'm fine with this being python3.
>
> A good follow-up test would be to see what happens if we push as much as
> possible to being python3.

OK, makes sense.

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH 1/1] Dockerfile: add python3-sphinx

[Tom Rini]

On Thu, Jul 25, 2019 at 10:34:28PM +0200, Heinrich Schuchardt wrote:

> python3-sphinx is needed to build the htmldocs target.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot-gitlab-ci-runner/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/fd5c860d/attachment.sig>