public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] edid: fix edid_get_timing_validate() mode_valid lookup
@ 2019-07-29 13:35 Neil Armstrong
  2019-07-29 17:16 ` Anatolij Gustschin
  0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2019-07-29 13:35 UTC (permalink / raw)
  To: u-boot

Add a condition to the break in the modes lookup, without this
when the first mode is not valid, then edid_get_timing_validate()
return an error instead of checking the next modes.

Fixes: 1c1ed441b0d1 ("edid: add edid_get_timing_validate() variant to filter out edid modes")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 common/edid.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/common/edid.c b/common/edid.c
index f244d26e04..f99f42dc40 100644
--- a/common/edid.c
+++ b/common/edid.c
@@ -202,7 +202,9 @@ int edid_get_timing_validate(u8 *buf, int buf_size,
 							 timing);
 			else
 				timing_done = true;
-			break;
+
+			if (timing_done)
+				break;
 		}
 	}
 	if (!timing_done)
-- 
2.22.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] edid: fix edid_get_timing_validate() mode_valid lookup
  2019-07-29 13:35 [U-Boot] [PATCH] edid: fix edid_get_timing_validate() mode_valid lookup Neil Armstrong
@ 2019-07-29 17:16 ` Anatolij Gustschin
  0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2019-07-29 17:16 UTC (permalink / raw)
  To: u-boot

On Mon, 29 Jul 2019 15:35:18 +0200
Neil Armstrong narmstrong at baylibre.com wrote:
...
>  common/edid.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to u-boot-video/master, thanks!

--
Anatolij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-29 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-29 13:35 [U-Boot] [PATCH] edid: fix edid_get_timing_validate() mode_valid lookup Neil Armstrong
2019-07-29 17:16 ` Anatolij Gustschin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox