public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command
@ 2019-07-24  8:53 Peng Fan
  2019-07-29 19:02 ` Anatolij Gustschin
  2019-08-13  8:30 ` Peng Fan
  0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan @ 2019-07-24  8:53 UTC (permalink / raw)
  To: u-boot

The gpio command currently uses equal bank names "GPIO0_"
for all existing gpio banks, i. e.:

U-Boot# gpio status -a
Bank GPIO0_:
GPIO0_0: input: 0 [ ]
GPIO0_1: input: 0 [ ]
...

Bank GPIO0_:
GPIO0_0: input: 0 [ ]
GPIO0_1: input: 0 [ ]
    ...

So the command is broken, it is not possible to address
a desired bank. Add gpio aliases to fix this.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/dts/fsl-imx8qm.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/dts/fsl-imx8qm.dtsi b/arch/arm/dts/fsl-imx8qm.dtsi
index af060db3a1..6808f68f9d 100644
--- a/arch/arm/dts/fsl-imx8qm.dtsi
+++ b/arch/arm/dts/fsl-imx8qm.dtsi
@@ -21,6 +21,13 @@
 	aliases {
 		ethernet0 = &fec1;
 		ethernet1 = &fec2;
+		gpio0 = &gpio1;
+		gpio1 = &gpio2;
+		gpio2 = &gpio3;
+		gpio3 = &gpio4;
+		gpio4 = &gpio5;
+		gpio5 = &gpio6;
+		gpio6 = &gpio7;
 		serial0 = &lpuart0;
 		serial1 = &lpuart1;
 		serial2 = &lpuart2;
-- 
2.16.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command
  2019-07-24  8:53 [U-Boot] [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command Peng Fan
@ 2019-07-29 19:02 ` Anatolij Gustschin
  2019-08-13  8:30 ` Peng Fan
  1 sibling, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2019-07-29 19:02 UTC (permalink / raw)
  To: u-boot

On Wed, 24 Jul 2019 08:53:08 +0000
Peng Fan peng.fan at nxp.com wrote:
... 
> So the command is broken, it is not possible to address
> a desired bank. Add gpio aliases to fix this.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>

--
Anatolij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command
  2019-07-24  8:53 [U-Boot] [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command Peng Fan
  2019-07-29 19:02 ` Anatolij Gustschin
@ 2019-08-13  8:30 ` Peng Fan
  1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2019-08-13  8:30 UTC (permalink / raw)
  To: u-boot

> Subject: [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio
> command
> 
> The gpio command currently uses equal bank names "GPIO0_"
> for all existing gpio banks, i. e.:
> 
> U-Boot# gpio status -a
> Bank GPIO0_:
> GPIO0_0: input: 0 [ ]
> GPIO0_1: input: 0 [ ]
> ...
> 
> Bank GPIO0_:
> GPIO0_0: input: 0 [ ]
> GPIO0_1: input: 0 [ ]
>     ...
> 
> So the command is broken, it is not possible to address a desired bank. Add
> gpio aliases to fix this.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---

Applied to nxp-imx-8-13,
https://github.com/MrVan/u-boot/tree/nxp-imx-8-13

Regards,
Peng.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-13  8:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24  8:53 [U-Boot] [PATCH] arm: dts: imx: fsl-imx8qm.dtsi: add gpio aliases to fix gpio command Peng Fan
2019-07-29 19:02 ` Anatolij Gustschin
2019-08-13  8:30 ` Peng Fan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox