public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: imx_lpi2c: add ipg clk
Date: Mon, 29 Jul 2019 21:37:10 +0200	[thread overview]
Message-ID: <20190729213710.5d1bf0a8@crub> (raw)
In-Reply-To: <20190724090940.14615-1-peng.fan@nxp.com>

Hi Peng,

On Wed, 24 Jul 2019 08:54:16 +0000
Peng Fan peng.fan at nxp.com wrote:
...
> +++ b/drivers/i2c/imx_lpi2c.c
> @@ -471,6 +471,17 @@ static int imx_lpi2c_probe(struct udevice *bus)
>  			dev_err(bus, "Failed to enable per clk\n");
>  			return ret;
>  		}
> +
> +		ret = clk_get_by_name(bus, "ipg", &i2c_bus->ipg_clk);
> +		if (ret) {
> +			dev_err(bus, "Failed to get ipg clk\n");
> +			return ret;
> +		}

imx8dx/imx8qxp device trees do not have ipg clock in I2C nodes, here
probing will fail. Should we add I2C ipg clock to imx8x dts files?
Or is it required only for imx8qm?

--
Anatolij

  reply	other threads:[~2019-07-29 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  8:54 [U-Boot] [PATCH] i2c: imx_lpi2c: add ipg clk Peng Fan
2019-07-29 19:37 ` Anatolij Gustschin [this message]
2019-07-30  0:45   ` Peng Fan
2019-07-30  7:17     ` Anatolij Gustschin
  -- strict thread matches above, loose matches on Subject: below --
2019-10-14 12:40 sbabic at denx.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729213710.5d1bf0a8@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox