From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Mon, 29 Jul 2019 21:37:10 +0200 Subject: [U-Boot] [PATCH] i2c: imx_lpi2c: add ipg clk In-Reply-To: <20190724090940.14615-1-peng.fan@nxp.com> References: <20190724090940.14615-1-peng.fan@nxp.com> Message-ID: <20190729213710.5d1bf0a8@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peng, On Wed, 24 Jul 2019 08:54:16 +0000 Peng Fan peng.fan at nxp.com wrote: ... > +++ b/drivers/i2c/imx_lpi2c.c > @@ -471,6 +471,17 @@ static int imx_lpi2c_probe(struct udevice *bus) > dev_err(bus, "Failed to enable per clk\n"); > return ret; > } > + > + ret = clk_get_by_name(bus, "ipg", &i2c_bus->ipg_clk); > + if (ret) { > + dev_err(bus, "Failed to get ipg clk\n"); > + return ret; > + } imx8dx/imx8qxp device trees do not have ipg clock in I2C nodes, here probing will fail. Should we add I2C ipg clock to imx8x dts files? Or is it required only for imx8qm? -- Anatolij