From: Matt Pelland <mpelland@starry.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: mvpp2: support setting hardware addresses from ethernet core
Date: Tue, 30 Jul 2019 09:40:22 -0400 [thread overview]
Message-ID: <20190730134023.16923-1-mpelland@starry.com> (raw)
In-Reply-To: <CANr=Z=b3UNTSDri7u5SpF-t5JKESFgGaqzgiK5yt+vNEQcL5FQ@mail.gmail.com>
> On Sat, Jun 1, 2019 at 1:39 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
> >
> > On Wed, May 8, 2019 at 2:36 PM Matt Pelland <mpelland@starry.com> wrote:
> > >
> > > mvpp2 already has support for setting MAC addresses but this
> > > functionality was not exposed to the ethernet core. This commit exposes
> > > this functionality so that MAC address assignments stored in U-Boot's
> > > environment are correctly applied before Linux boots.
> > >
> > > Signed-off-by: Matt Pelland <mpelland@starry.com>
> > > ---
> > > drivers/net/mvpp2.c | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
> > > index bcc6fe92a9..d2d17f1417 100644
> > > --- a/drivers/net/mvpp2.c
> > > +++ b/drivers/net/mvpp2.c
> > > @@ -5321,6 +5321,13 @@ static void mvpp2_stop(struct udevice *dev)
> > > mvpp2_cleanup_txqs(port);
> > > }
> > >
> > > +static mvpp2_write_hwaddr(struct udevice *dev)
> >
> > This breaks the build. The function must return an int.
>
> Should we expect an update to this patch or drop it from patchwork?
Hi Joe,
Many apologies for the delay on this. I had my email filters misconfigured and
things were getting sent to an archive instead of my inbox. I've cleaned up the
patch in question.
Thanks,
Matt
next prev parent reply other threads:[~2019-07-30 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 19:34 [U-Boot] [PATCH] net: mvpp2: support setting hardware addresses from ethernet core Matt Pelland
2019-05-08 21:53 ` Joe Hershberger
2019-05-09 5:17 ` Stefan Roese
2019-06-01 18:40 ` Joe Hershberger
2019-07-08 19:00 ` Joe Hershberger
2019-07-30 13:40 ` Matt Pelland [this message]
2019-07-30 13:40 ` [U-Boot] [PATCH v2] " Matt Pelland
2019-07-30 22:19 ` Joe Hershberger
2019-09-04 16:40 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730134023.16923-1-mpelland@starry.com \
--to=mpelland@starry.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox