[U-Boot] [PATCH] pci_ep: Fix Coverity warning

[U-Boot] [PATCH] pci_ep: Fix Coverity warning

[Ramon Fried]

Fix the following Coverity warning:
CID 244086:  Incorrect expression  (BAD_COMPARE)
Comparing pointer "ep_bar" against NULL using anything besides == or
is likely to be incorrect.

Fixes: 914026d25848 ("drivers: pci_ep: Introduce UCLASS_PCI_EP uclass")

Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
---
 drivers/pci_endpoint/pci_ep-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci_endpoint/pci_ep-uclass.c b/drivers/pci_endpoint/pci_ep-uclass.c
index 2f9c70398d..9f53a9a9b9 100644
--- a/drivers/pci_endpoint/pci_ep-uclass.c
+++ b/drivers/pci_endpoint/pci_ep-uclass.c
@@ -43,7 +43,7 @@ int pci_ep_set_bar(struct udevice *dev, uint func_no, struct pci_bar *ep_bar)
 	int flags = ep_bar->flags;
 
 	/* Some basic bar validity checks */
-	if (ep_bar->barno > BAR_5 || ep_bar < BAR_0)
+	if (ep_bar->barno > BAR_5 || ep_bar->barno < BAR_0)
 		return -EINVAL;
 
 	if ((ep_bar->barno == BAR_5 &&
-- 
2.20.1

[U-Boot] [PATCH] pci_ep: Fix Coverity warning

[Tom Rini]

On Wed, Jul 31, 2019 at 11:04:26AM +0300, Ramon Fried wrote:

> Fix the following Coverity warning:
> CID 244086:  Incorrect expression  (BAD_COMPARE)
> Comparing pointer "ep_bar" against NULL using anything besides == or
> is likely to be incorrect.
> 
> Fixes: 914026d25848 ("drivers: pci_ep: Introduce UCLASS_PCI_EP uclass")
> 
> Signed-off-by: Ramon Fried <rfried.dev@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190807/1eb7e0f1/attachment.sig>