From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] serial: lpuart: request dm device removal when booting OS
Date: Wed, 31 Jul 2019 15:11:47 +0200 [thread overview]
Message-ID: <20190731151147.731e41d6@crub> (raw)
In-Reply-To: <AM0PR04MB4481E46D2493AE61DC31E14E88CF0@AM0PR04MB4481.eurprd04.prod.outlook.com>
Hi Peng,
On Mon, 15 Jul 2019 03:02:46 +0000
Peng Fan peng.fan at nxp.com wrote:
...
> > +static int lpuart_serial_remove(struct udevice *dev) {
> > + if (dev == gd->cur_serial_dev)
> > + dev->flags |= DM_FLAG_REMOVE_WITH_PD_ON;
>
> How about introduce a device tree property for DM? Then
> Set the flags in common code, not in specific driver.
we should not add more DT properties which are not describing the
hardware, I think. Current plan is to drop this patch and do additional
check dev != gd->cur_serial_dev in device_remove(), as Lokesh suggested.
--
Anatolij
next prev parent reply other threads:[~2019-07-31 13:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 19:57 [U-Boot] [PATCH v2 1/2] dm: core: device: switch off power domain after device removal Anatolij Gustschin
2019-07-14 19:57 ` [U-Boot] [PATCH v2 2/2] serial: lpuart: request dm device removal when booting OS Anatolij Gustschin
2019-07-15 3:02 ` Peng Fan
2019-07-31 13:11 ` Anatolij Gustschin [this message]
2019-07-15 2:59 ` [U-Boot] [PATCH v2 1/2] dm: core: device: switch off power domain after device removal Peng Fan
2019-07-18 15:22 ` Simon Glass
2019-07-31 16:01 ` Anatolij Gustschin
2019-07-31 16:29 ` Simon Glass
2019-07-31 17:02 ` Anatolij Gustschin
2019-07-23 14:05 ` Lokesh Vutla
2019-07-31 13:13 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731151147.731e41d6@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox