public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: da850-evm: Fix Lowlevel init
@ 2019-08-01 13:47 Adam Ford
  2019-08-13 16:51 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2019-08-01 13:47 UTC (permalink / raw)
  To: u-boot

A previous patch for enabling the NAND config set a flag called
CONFIG_SKIP_LOWLEVEL_INIT when it should have been called
CONFIG_SKIP_LOWLEVEL_INIT_ONLY.  The affect this had was creating
a delay on startup for the NOR version which is XIP and doesn't have
SPL, so the lowlevel initialization functions need to operate.
This delay was not really noticeable at first, but the delays have been
getting longer, finally reached the point of nearly seven seconds
before the board would appear to start.

This patch sets the CONFIG_SKIP_LOWLEVEL_INIT_ONLY instead which means
"The normal CP15 init (such as enabling the instruction cache) is still
performed" per the README.  It doesn't appear to have any adverse
behavior on the SPI Flash or the NAND flash boards which use SPL.

Fixes: 93f3362762f0 ("ARM: configs: Add da850evm_nand to boot from NAND")

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
index ff536131ba..0281dbd7b4 100644
--- a/include/configs/da850evm.h
+++ b/include/configs/da850evm.h
@@ -26,7 +26,7 @@
 #define CONFIG_SYS_OSCIN_FREQ		24000000
 #define CONFIG_SYS_TIMERBASE		DAVINCI_TIMER0_BASE
 #define CONFIG_SYS_HZ_CLOCK		clk_get(DAVINCI_AUXCLK_CLKID)
-#define CONFIG_SKIP_LOWLEVEL_INIT
+#define CONFIG_SKIP_LOWLEVEL_INIT_ONLY
 
 #ifdef CONFIG_DIRECT_NOR_BOOT
 #define CONFIG_ARCH_CPU_INIT
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] ARM: da850-evm: Fix Lowlevel init
  2019-08-01 13:47 [U-Boot] [PATCH] ARM: da850-evm: Fix Lowlevel init Adam Ford
@ 2019-08-13 16:51 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-08-13 16:51 UTC (permalink / raw)
  To: u-boot

On Thu, Aug 01, 2019 at 08:47:55AM -0500, Adam Ford wrote:

> A previous patch for enabling the NAND config set a flag called
> CONFIG_SKIP_LOWLEVEL_INIT when it should have been called
> CONFIG_SKIP_LOWLEVEL_INIT_ONLY.  The affect this had was creating
> a delay on startup for the NOR version which is XIP and doesn't have
> SPL, so the lowlevel initialization functions need to operate.
> This delay was not really noticeable at first, but the delays have been
> getting longer, finally reached the point of nearly seven seconds
> before the board would appear to start.
> 
> This patch sets the CONFIG_SKIP_LOWLEVEL_INIT_ONLY instead which means
> "The normal CP15 init (such as enabling the instruction cache) is still
> performed" per the README.  It doesn't appear to have any adverse
> behavior on the SPI Flash or the NAND flash boards which use SPL.
> 
> Fixes: 93f3362762f0 ("ARM: configs: Add da850evm_nand to boot from NAND")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
> index ff536131ba..0281dbd7b4 100644

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190813/3756cc46/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-13 16:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-01 13:47 [U-Boot] [PATCH] ARM: da850-evm: Fix Lowlevel init Adam Ford
2019-08-13 16:51 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox