* [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing
@ 2019-08-06 10:07 Peng Fan
2019-08-07 9:55 ` Ye Li
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peng Fan @ 2019-08-06 10:07 UTC (permalink / raw)
To: u-boot
Add missed break for HDMI entry.
And moving FIT parsing earlier, because it does not have parameter,
it will not runs into CFG_REG_SIZE.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
tools/imx8mimage.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
index 50a256cbac..6c02337698 100644
--- a/tools/imx8mimage.c
+++ b/tools/imx8mimage.c
@@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token, char *name, int lineno)
break;
case CMD_SIGNED_HDMI:
signed_hdmi = token;
- case CMD_FIT:
- using_fit = 1;
break;
case CMD_DDR_FW:
/* Do nothing */
@@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char *token,
name, lineno, token);
exit(EXIT_FAILURE);
}
+ switch (*cmd) {
+ case CMD_FIT:
+ using_fit = 1;
+ break;
+ }
break;
case CFG_REG_SIZE:
parse_cfg_cmd(*cmd, token, name, lineno);
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing
2019-08-06 10:07 [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing Peng Fan
@ 2019-08-07 9:55 ` Ye Li
2019-08-08 7:03 ` Lukasz Majewski
2019-08-13 8:27 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Ye Li @ 2019-08-07 9:55 UTC (permalink / raw)
To: u-boot
> Add missed break for HDMI entry.
> And moving FIT parsing earlier, because it does not have parameter,
> it will not runs into CFG_REG_SIZE.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> tools/imx8mimage.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
> index 50a256cbac..6c02337698 100644
> --- a/tools/imx8mimage.c
> +++ b/tools/imx8mimage.c
> @@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token, char *name, int lineno)
> break;
> case CMD_SIGNED_HDMI:
> signed_hdmi = token;
> - case CMD_FIT:
> - using_fit = 1;
> break;
> case CMD_DDR_FW:
> /* Do nothing */
> @@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char *token,
> name, lineno, token);
> exit(EXIT_FAILURE);
> }
> + switch (*cmd) {
> + case CMD_FIT:
> + using_fit = 1;
> + break;
> + }
> break;
> case CFG_REG_SIZE:
> parse_cfg_cmd(*cmd, token, name, lineno);
>
Reviewed-by: Ye Li <ye.li@nxp.com>
Best regards,
Ye Li
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing
2019-08-06 10:07 [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing Peng Fan
2019-08-07 9:55 ` Ye Li
@ 2019-08-08 7:03 ` Lukasz Majewski
2019-08-13 8:27 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Lukasz Majewski @ 2019-08-08 7:03 UTC (permalink / raw)
To: u-boot
On Tue, 6 Aug 2019 10:07:26 +0000
Peng Fan <peng.fan@nxp.com> wrote:
> Add missed break for HDMI entry.
> And moving FIT parsing earlier, because it does not have parameter,
> it will not runs into CFG_REG_SIZE.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> tools/imx8mimage.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
> index 50a256cbac..6c02337698 100644
> --- a/tools/imx8mimage.c
> +++ b/tools/imx8mimage.c
> @@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token,
> char *name, int lineno) break;
> case CMD_SIGNED_HDMI:
> signed_hdmi = token;
> - case CMD_FIT:
> - using_fit = 1;
> break;
> case CMD_DDR_FW:
> /* Do nothing */
> @@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char
> *token, name, lineno, token);
> exit(EXIT_FAILURE);
> }
> + switch (*cmd) {
> + case CMD_FIT:
> + using_fit = 1;
> + break;
> + }
> break;
> case CFG_REG_SIZE:
> parse_cfg_cmd(*cmd, token, name, lineno);
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190808/bb930389/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing
2019-08-06 10:07 [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing Peng Fan
2019-08-07 9:55 ` Ye Li
2019-08-08 7:03 ` Lukasz Majewski
@ 2019-08-13 8:27 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2019-08-13 8:27 UTC (permalink / raw)
To: u-boot
> Subject: [PATCH] tools: imx8mimage: fix HDMI/FIT parsing
>
> Add missed break for HDMI entry.
> And moving FIT parsing earlier, because it does not have parameter, it will not
> runs into CFG_REG_SIZE.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Applied to nxp-imx-8-13,
https://github.com/MrVan/u-boot/tree/nxp-imx-8-13
Regards,
Peng.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-13 8:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06 10:07 [U-Boot] [PATCH] tools: imx8mimage: fix HDMI/FIT parsing Peng Fan
2019-08-07 9:55 ` Ye Li
2019-08-08 7:03 ` Lukasz Majewski
2019-08-13 8:27 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox