From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 20 Aug 2019 12:19:32 -0400 Subject: [U-Boot] [PATCH v3 8/8] ata: ahci: Don't forget to clear upper address regs. In-Reply-To: <20190806150852.5527-9-frank-w@public-files.de> References: <20190806150852.5527-1-frank-w@public-files.de> <20190806150852.5527-9-frank-w@public-files.de> Message-ID: <20190820161932.GA3562@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 06, 2019 at 05:08:52PM +0200, Frank Wunderlich wrote: > From: Oleksandr Rybalko > > In 32bits mode upper bits need to be set to 0, otherwise controller will > try to DMA into not existing memory and stops with error. > > changes since v2: none > > Tested-by: Frank Wunderlich > Signed-off-by: Frank Wunderlich > Signed-off-by: Oleksandr Rybalko This introduces a warning: x86: w+ qemu-x86_64 +(qemu-x86_64) writel_with_flush((u32)pp->cmd_slot, port_mmio + PORT_LST_ADDR); +(qemu-x86_64) ^ +(qemu-x86_64) arch/x86/include/asm/io.h:71:53: note: in definition of macro 'writel' +(qemu-x86_64) #define writel(b, addr) (*(volatile u32 *)(addr) = (b)) +(qemu-x86_64) ^ +(qemu-x86_64) drivers/ata/ahci.c:596:2: note: in expansion of macro 'writel_with_flush' +(qemu-x86_64) ^~~~~~~~~~~~~~~~~ w+(qemu-x86_64) drivers/ata/ahci.c: In function 'ahci_port_start': w+(qemu-x86_64) drivers/ata/ahci.c:596:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: