From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 23 Aug 2019 10:37:28 +0200 Subject: [U-Boot] [PATCH 1/2] sunxi: fix support board-specific CONFIG_PREBOOT In-Reply-To: <20190818151607.9711-1-dr@jones.dk> References: <20190818151607.9711-1-dr@jones.dk> Message-ID: <20190823103728.7abd2a27@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 18 Aug 2019 17:16:06 +0200 Jonas Smedegaard wrote: > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > Kconfig") intended to support CONFIG_PREBOOT, but > include/configs/sunxi-common.h hardcodes preboot as part of internally > defined CONSOLE_STDIN_SETTINGS, silently ignoring any board-specific > CONFIG_PREBOOT. > > Tested-by: Jonas Smedegaard > Signed-off-by: Jonas Smedegaard > Series-Cc: Jagan Teki > --- > > include/configs/sunxi-common.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/configs/sunxi-common.h > b/include/configs/sunxi-common.h index d7133a73fc..2069884b63 100644 > --- a/include/configs/sunxi-common.h > +++ b/include/configs/sunxi-common.h > @@ -432,8 +432,13 @@ extern int soft_i2c_gpio_scl; > #include > > #ifdef CONFIG_USB_KEYBOARD > +#ifdef CONFIG_USE_PREBOOT > +#ifndef CONFIG_PREBOOT > +#define CONFIG_PREBOOT \ > + "usb start" Shouldn't this (CONFIG_PREBOOT) be set in the Kconfig? > +#endif > +#endif > #define CONSOLE_STDIN_SETTINGS \ > - "preboot=usb start\0" \ > "stdin=serial,usbkbd\0" > #else > #define CONSOLE_STDIN_SETTINGS \ Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: