From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 3/4] x86: tangier: Fix off-by-one error when preparing CSRT
Date: Thu, 29 Aug 2019 17:04:20 +0300 [thread overview]
Message-ID: <20190829140421.2830-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20190829140421.2830-1-andriy.shevchenko@linux.intel.com>
Intel iDMA 32-bit controller has 17 bits for the maximum block size value.
Due to nature of the binary number representation the maximum value is
2^17 - 1. The original code misses the latter part in equation.
Fixes: 5e99fde34a77 ("x86: tangier: Populate CSRT for shared DMA controller")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/cpu/tangier/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/tangier/acpi.c
index 362e133cf1..8b128138b0 100644
--- a/arch/x86/cpu/tangier/acpi.c
+++ b/arch/x86/cpu/tangier/acpi.c
@@ -95,7 +95,7 @@ static u32 acpi_fill_csrt_dma(struct acpi_csrt_group *grp)
si->dma_address_width = 32;
si->base_request_line = 0;
si->num_handshake_signals = 16;
- si->max_block_size = 0x20000;
+ si->max_block_size = 0x1ffff;
return grp->length;
}
--
2.23.0.rc1
next prev parent reply other threads:[~2019-08-29 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:04 [U-Boot] [PATCH v1 1/4] x86: acpi: Annotate struct acpi_table_header with __packed Andy Shevchenko
2019-08-29 14:04 ` [U-Boot] [PATCH v1 2/4] x86: tangier: Reserve PCI ECAM in motherboard resources Andy Shevchenko
2019-09-10 8:14 ` Bin Meng
2019-09-10 8:21 ` Bin Meng
2019-08-29 14:04 ` Andy Shevchenko [this message]
2019-09-10 8:14 ` [U-Boot] [PATCH v1 3/4] x86: tangier: Fix off-by-one error when preparing CSRT Bin Meng
2019-09-10 8:21 ` Bin Meng
2019-08-29 14:04 ` [U-Boot] [PATCH v1 4/4] x86: tangier: Use spaces over TABs in ASL code Andy Shevchenko
2019-09-10 8:14 ` Bin Meng
2019-09-10 8:21 ` Bin Meng
2019-08-29 14:13 ` [U-Boot] [PATCH v1 1/4] x86: acpi: Annotate struct acpi_table_header with __packed Bin Meng
2019-08-29 14:28 ` Andy Shevchenko
2019-09-10 8:14 ` Bin Meng
2019-09-10 8:20 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829140421.2830-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox