U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx53loco: Fix U-Boot corruption after saving the environment
Date: Tue, 3 Sep 2019 10:36:08 -0400	[thread overview]
Message-ID: <20190903143608.GF26850@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5Dn2pkG36r+dnD6D+vx8gSjUh8KoHGaQhBYyqdk6etXcg@mail.gmail.com>

On Mon, Sep 02, 2019 at 01:40:27PM -0300, Fabio Estevam wrote:
> Hi Tom,
> 
> On Fri, Aug 30, 2019 at 3:14 PM Tom Rini <trini@konsulko.com> wrote:
> 
> > Are there more i.mx platforms that are not setting BOARD_SIZE_LIMIT
> > today?  I assume there are, sadly.  Can you audit and catch the rest of
> 
> Yes, only a very few i.MX boards set BOARD_SIZE_LIMIT currently.
> 
> > these likely problems, and add limits so we won't repeat this again.
> 
> Yes, I can audit this, but this task requires more time and I can do
> that after 2019.10 is released.
> 
> Could this one that fixes mx53qsb be applied for 2019.10?

As some is better than none, yes, we should fix and detect this for this
platform.  But I am a little frustrated in that this is not a new
problem and the hook to check for this problem was put in back in June,
so I had hoped for more preemptive conversions.  It's also on me for
having not reminded folks about that too.  So please, can we make sure
to get this covered ASAP?  I think the kludge patch I've posted and
linked to before (http://patchwork.ozlabs.org/patch/790476/) can be used
here to get a current value calculated and spit out.  Moving the
question to Kconfig would then make it easier still to:
1. sync all configs
2. loop over appending value to defconfigs
3. re-sync all defconfigs
4. drop first patch, squash next
approximately anyhow.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190903/b628a8a1/attachment.sig>

      reply	other threads:[~2019-09-03 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 16:58 [U-Boot] [PATCH] mx53loco: Fix U-Boot corruption after saving the environment Fabio Estevam
2019-08-30 18:14 ` Tom Rini
2019-09-02 16:40   ` Fabio Estevam
2019-09-03 14:36     ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903143608.GF26850@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox