[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Lukasz Majewski]

This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.

The mxs_spi.c driver for i.MX2{38} devices has been converted:
'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPI conversion)")'

to use Device Tree and Device Model, so the DEPRECATED Kconfig
symbol can be now removed.

Signed-off-by: Lukasz Majewski <lukma@denx.de>

---

 drivers/spi/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f459c0a411..8dd3213d48 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -419,7 +419,6 @@ config MXC_SPI
 
 config MXS_SPI
 	bool "MXS SPI Driver"
-	depends on DEPRECATED
 	help
 	  Enable the MXS SPI controller driver. This driver can be used
 	  on the i.MX23 and i.MX28 SoCs.
-- 
2.11.0

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Lukasz Majewski]

Hi Jagan,

> This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
> 
> The mxs_spi.c driver for i.MX2{38} devices has been converted:
> 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> SPI driver (DM_SPI conversion)")'
> 
> to use Device Tree and Device Model, so the DEPRECATED Kconfig
> symbol can be now removed.

Gentle ping on this patch.

> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> 
> ---
> 
>  drivers/spi/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f459c0a411..8dd3213d48 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -419,7 +419,6 @@ config MXC_SPI
>  
>  config MXS_SPI
>  	bool "MXS SPI Driver"
> -	depends on DEPRECATED
>  	help
>  	  Enable the MXS SPI controller driver. This driver can be
> used on the i.MX23 and i.MX28 SoCs.



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190903/fb735a18/attachment.sig>

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Jagan Teki]

On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
>
> This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.

This wouldn't be a revert.

The deprecated patch been merged in May, 29 and

>
> The mxs_spi.c driver for i.MX2{38} devices has been converted:
> 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPI conversion)")'

This was merged in June, 19 so please send a separate patch. I was
expected this changes would be part of dm spi conversion on that
driver.

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Lukasz Majewski]

Hi Jagan,

> On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> >
> > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.  
> 
> This wouldn't be a revert.
> 
> The deprecated patch been merged in May, 29 and
> 
> >
> > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > SPI driver (DM_SPI conversion)")'  
> 
> This was merged in June, 19 so please send a separate patch.

Cannot we just revert the patch? Is there any issue or technical
problem with doing that ?

> I was
> expected this changes would be part of dm spi conversion on that
> driver.

Ok.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/8c7bc669/attachment.sig>

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Tom Rini]

On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> Hi Jagan,
> 
> > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> > >
> > > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.  
> > 
> > This wouldn't be a revert.
> > 
> > The deprecated patch been merged in May, 29 and
> > 
> > >
> > > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > > SPI driver (DM_SPI conversion)")'  
> > 
> > This was merged in June, 19 so please send a separate patch.
> 
> Cannot we just revert the patch? Is there any issue or technical
> problem with doing that ?

To me it's a fairly odd to say revert.  It's "re-enable" of support.
That said, Jagan, can you just reword the commit or something?  It needs
to go in either way and the contents don't change.  Thanks all!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/6de5722d/attachment.sig>

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Jagan Teki]

On Sat, Sep 7, 2019 at 4:32 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> > Hi Jagan,
> >
> > > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> > > >
> > > > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
> > >
> > > This wouldn't be a revert.
> > >
> > > The deprecated patch been merged in May, 29 and
> > >
> > > >
> > > > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > > > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > > > SPI driver (DM_SPI conversion)")'
> > >
> > > This was merged in June, 19 so please send a separate patch.
> >
> > Cannot we just revert the patch? Is there any issue or technical
> > problem with doing that ?
>
> To me it's a fairly odd to say revert.  It's "re-enable" of support.
> That said, Jagan, can you just reword the commit or something?  It needs
> to go in either way and the contents don't change.  Thanks all!

Updated the commit message, and

Applied to u-boot-spi/master

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Tom Rini]

On Sat, Sep 07, 2019 at 09:06:39AM +0530, Jagan Teki wrote:
> On Sat, Sep 7, 2019 at 4:32 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> > > Hi Jagan,
> > >
> > > > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> > > > >
> > > > > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
> > > >
> > > > This wouldn't be a revert.
> > > >
> > > > The deprecated patch been merged in May, 29 and
> > > >
> > > > >
> > > > > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > > > > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > > > > SPI driver (DM_SPI conversion)")'
> > > >
> > > > This was merged in June, 19 so please send a separate patch.
> > >
> > > Cannot we just revert the patch? Is there any issue or technical
> > > problem with doing that ?
> >
> > To me it's a fairly odd to say revert.  It's "re-enable" of support.
> > That said, Jagan, can you just reword the commit or something?  It needs
> > to go in either way and the contents don't change.  Thanks all!
> 
> Updated the commit message, and

Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190907/b8a26ea9/attachment.sig>

[U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

[Lukasz Majewski]

Hi Tom, Jagan,

> On Sat, Sep 07, 2019 at 09:06:39AM +0530, Jagan Teki wrote:
> > On Sat, Sep 7, 2019 at 4:32 AM Tom Rini <trini@konsulko.com> wrote:
> >  
> > >
> > > On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:  
> > > > Hi Jagan,
> > > >  
> > > > > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski
> > > > > <lukma@denx.de> wrote:  
> > > > > >
> > > > > > This reverts commit
> > > > > > d5ded320a14b0a2f97cbed072286748895ad18ac.  
> > > > >
> > > > > This wouldn't be a revert.
> > > > >
> > > > > The deprecated patch been merged in May, 29 and
> > > > >  
> > > > > >
> > > > > > The mxs_spi.c driver for i.MX2{38} devices has been
> > > > > > converted: 'commit d99b018a6e3d ("spi: mxs: Add support
> > > > > > DM/DTS for i.MX28 mxs SPI driver (DM_SPI conversion)")'  
> > > > >
> > > > > This was merged in June, 19 so please send a separate patch.  
> > > >
> > > > Cannot we just revert the patch? Is there any issue or technical
> > > > problem with doing that ?  
> > >
> > > To me it's a fairly odd to say revert.  It's "re-enable" of
> > > support. That said, Jagan, can you just reword the commit or
> > > something?  It needs to go in either way and the contents don't
> > > change.  Thanks all!  
> > 
> > Updated the commit message, and  
> 
> Thanks!
> 

Jagan, thanks for the reword :-)

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190907/6bb6b097/attachment.sig>