From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
Date: Fri, 6 Sep 2019 19:02:02 -0400 [thread overview]
Message-ID: <20190906230202.GA6927@bill-the-cat> (raw)
In-Reply-To: <20190906233246.64669aa2@jawa>
On Fri, Sep 06, 2019 at 11:32:46PM +0200, Lukasz Majewski wrote:
> Hi Jagan,
>
> > On Thu, Aug 1, 2019 at 9:27 PM Lukasz Majewski <lukma@denx.de> wrote:
> > >
> > > This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
> >
> > This wouldn't be a revert.
> >
> > The deprecated patch been merged in May, 29 and
> >
> > >
> > > The mxs_spi.c driver for i.MX2{38} devices has been converted:
> > > 'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs
> > > SPI driver (DM_SPI conversion)")'
> >
> > This was merged in June, 19 so please send a separate patch.
>
> Cannot we just revert the patch? Is there any issue or technical
> problem with doing that ?
To me it's a fairly odd to say revert. It's "re-enable" of support.
That said, Jagan, can you just reword the commit or something? It needs
to go in either way and the contents don't change. Thanks all!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/6de5722d/attachment.sig>
next prev parent reply other threads:[~2019-09-06 23:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 15:56 [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED" Lukasz Majewski
2019-09-03 14:19 ` Lukasz Majewski
2019-09-06 18:06 ` Jagan Teki
2019-09-06 21:32 ` Lukasz Majewski
2019-09-06 23:02 ` Tom Rini [this message]
2019-09-07 3:36 ` Jagan Teki
2019-09-07 17:03 ` Tom Rini
2019-09-07 19:35 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906230202.GA6927@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox