From: Patrick Delaunay <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 06/16] dfu: allow read with no data without error for EOF indication
Date: Mon, 30 Sep 2019 15:38:22 +0200 [thread overview]
Message-ID: <20190930133832.11992-7-patrick.delaunay@st.com> (raw)
In-Reply-To: <20190930133832.11992-1-patrick.delaunay@st.com>
This patch allows the DFU backend to indicate that that it can't
provide no more data to fill the DFU buffer, by setting b_left =0
without error, even if the size of received data is lower of the
expected total size indicated by get_medium_size.
For USB DFU stack point of view, it is acceptable:
the read length < requested size in DFU_UPLOAD and the
transaction is stopped.
That avoid infinite loop issue in dfu_read_buffer_fill because the
size for the DFU read is limited by get_medium_size = r_left
and the DFU stack expects that read is allowed up to this size.
This issue never occurs for current flash device (where chunk are
always completely read, and b_left will be never 0) but it is useful for
virtual partition when the backend only know the max size of this
alternate, the real size of the data are only known in the read
treatment.
PS: for file access on mmc, EOF is never reached as
dfu_get_medium_size_mmc returns the exact size of the file.
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
Changes in v2:
- Update commit message
drivers/dfu/dfu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index 8bd5216017..50919fcae9 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -396,6 +396,8 @@ static int dfu_read_buffer_fill(struct dfu_entity *dfu, void *buf, int size)
debug("%s: Read error!\n", __func__);
return ret;
}
+ if (dfu->b_left == 0)
+ break;
dfu->offset += dfu->b_left;
dfu->r_left -= dfu->b_left;
--
2.17.1
next prev parent reply other threads:[~2019-09-30 13:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 13:38 [U-Boot] [PATCH v2 00/16] dfu: update dfu stack and add MTD backend Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 01/16] dfu: cosmetic: cleanup sf to avoid checkpatch error Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 02/16] doc: dfu: Add dfu documentation Patrick Delaunay
2019-10-10 10:04 ` Lukasz Majewski
2019-09-30 13:38 ` [U-Boot] [PATCH v2 03/16] dfu: sf: add partition support for nor backend Patrick Delaunay
2019-10-10 10:11 ` Lukasz Majewski
2019-10-11 8:05 ` [U-Boot] [Uboot-stm32] " Patrick DELAUNAY
2019-09-30 13:38 ` [U-Boot] [PATCH v2 04/16] dfu: prepare the support of multiple interface Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 05/16] dfu: allow to manage DFU on several devices Patrick Delaunay
2019-09-30 13:38 ` Patrick Delaunay [this message]
2019-09-30 13:38 ` [U-Boot] [PATCH v2 07/16] dfu: add backend for MTD device Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 08/16] dfu: add partition support for MTD backend Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 09/16] dfu: add DFU virtual backend Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 10/16] dfu: add callback for flush and initiated operation Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 11/16] stm32mp1: activate DFU support and command MTD Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 12/16] stm32mp1: activate SET_DFU_ALT_INFO Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 13/16] stm32mp1: configs: activate CONFIG_MTD_SPI_NAND Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 14/16] stm32mp1: board: add spi nand support Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 15/16] stm32mp1: add support for virtual partition read Patrick Delaunay
2019-09-30 13:38 ` [U-Boot] [PATCH v2 16/16] board: stm32mp1: fixup the usb product id for USB download gadget Patrick Delaunay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930133832.11992-7-patrick.delaunay@st.com \
--to=patrick.delaunay@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox