* [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"
@ 2019-08-22 7:47 AKASHI Takahiro
2019-08-27 1:12 ` Bin Meng
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: AKASHI Takahiro @ 2019-08-22 7:47 UTC (permalink / raw)
To: u-boot
With the patch below applied, host_block_dev structure was switched
to be placed in platdata rather than priv. The command "host info"
must be aligned with this change. Otherwise, we will see "Segmentation
Fault."
Fixes: 8f994c860d91 ("sandbox: blk: Switch to use platdata_auto_alloc_size for the driver data")
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
cmd/host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/host.c b/cmd/host.c
index f7d3eae5b1ad..98c4d2a099e9 100644
--- a/cmd/host.c
+++ b/cmd/host.c
@@ -89,7 +89,7 @@ static int do_host_info(cmd_tbl_t *cmdtp, int flag, int argc,
struct host_block_dev *host_dev;
#ifdef CONFIG_BLK
- host_dev = dev_get_priv(blk_dev->bdev);
+ host_dev = dev_get_platdata(blk_dev->bdev);
#else
host_dev = blk_dev->priv;
#endif
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"
2019-08-22 7:47 [U-Boot] [PATCH] cmd: host: fix seg fault at "host info" AKASHI Takahiro
@ 2019-08-27 1:12 ` Bin Meng
2019-08-27 2:54 ` Heinrich Schuchardt
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2019-08-27 1:12 UTC (permalink / raw)
To: u-boot
On Thu, Aug 22, 2019 at 3:45 PM AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
>
> With the patch below applied, host_block_dev structure was switched
> to be placed in platdata rather than priv. The command "host info"
> must be aligned with this change. Otherwise, we will see "Segmentation
> Fault."
>
> Fixes: 8f994c860d91 ("sandbox: blk: Switch to use platdata_auto_alloc_size for the driver data")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> cmd/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"
2019-08-22 7:47 [U-Boot] [PATCH] cmd: host: fix seg fault at "host info" AKASHI Takahiro
2019-08-27 1:12 ` Bin Meng
@ 2019-08-27 2:54 ` Heinrich Schuchardt
2019-10-03 6:04 ` AKASHI Takahiro
2019-10-06 22:03 ` Tom Rini
3 siblings, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2019-08-27 2:54 UTC (permalink / raw)
To: u-boot
On 8/22/19 9:47 AM, AKASHI Takahiro wrote:
> With the patch below applied, host_block_dev structure was switched
> to be placed in platdata rather than priv. The command "host info"
> must be aligned with this change. Otherwise, we will see "Segmentation
> Fault."
>
> Fixes: 8f994c860d91 ("sandbox: blk: Switch to use platdata_auto_alloc_size for the driver data")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> cmd/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/host.c b/cmd/host.c
> index f7d3eae5b1ad..98c4d2a099e9 100644
> --- a/cmd/host.c
> +++ b/cmd/host.c
> @@ -89,7 +89,7 @@ static int do_host_info(cmd_tbl_t *cmdtp, int flag, int argc,
> struct host_block_dev *host_dev;
>
> #ifdef CONFIG_BLK
> - host_dev = dev_get_priv(blk_dev->bdev);
> + host_dev = dev_get_platdata(blk_dev->bdev);
> #else
> host_dev = blk_dev->priv;
> #endif
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"
2019-08-22 7:47 [U-Boot] [PATCH] cmd: host: fix seg fault at "host info" AKASHI Takahiro
2019-08-27 1:12 ` Bin Meng
2019-08-27 2:54 ` Heinrich Schuchardt
@ 2019-10-03 6:04 ` AKASHI Takahiro
2019-10-03 7:27 ` Bin Meng
2019-10-06 22:03 ` Tom Rini
3 siblings, 1 reply; 6+ messages in thread
From: AKASHI Takahiro @ 2019-10-03 6:04 UTC (permalink / raw)
To: u-boot
Ping,
This patch has not been merged yet.
-Takahiro Akashi
On Thu, Aug 22, 2019 at 04:47:39PM +0900, AKASHI Takahiro wrote:
> With the patch below applied, host_block_dev structure was switched
> to be placed in platdata rather than priv. The command "host info"
> must be aligned with this change. Otherwise, we will see "Segmentation
> Fault."
>
> Fixes: 8f994c860d91 ("sandbox: blk: Switch to use platdata_auto_alloc_size for the driver data")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> cmd/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/host.c b/cmd/host.c
> index f7d3eae5b1ad..98c4d2a099e9 100644
> --- a/cmd/host.c
> +++ b/cmd/host.c
> @@ -89,7 +89,7 @@ static int do_host_info(cmd_tbl_t *cmdtp, int flag, int argc,
> struct host_block_dev *host_dev;
>
> #ifdef CONFIG_BLK
> - host_dev = dev_get_priv(blk_dev->bdev);
> + host_dev = dev_get_platdata(blk_dev->bdev);
> #else
> host_dev = blk_dev->priv;
> #endif
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"
2019-10-03 6:04 ` AKASHI Takahiro
@ 2019-10-03 7:27 ` Bin Meng
0 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2019-10-03 7:27 UTC (permalink / raw)
To: u-boot
+Tom
On Thu, Oct 3, 2019 at 2:00 PM AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
>
> Ping,
>
> This patch has not been merged yet.
>
Simon is on vacation.
Tom, could you please take this patch directly? This needs to be in v2019.10.
Regards,
Bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"
2019-08-22 7:47 [U-Boot] [PATCH] cmd: host: fix seg fault at "host info" AKASHI Takahiro
` (2 preceding siblings ...)
2019-10-03 6:04 ` AKASHI Takahiro
@ 2019-10-06 22:03 ` Tom Rini
3 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2019-10-06 22:03 UTC (permalink / raw)
To: u-boot
On Thu, Aug 22, 2019 at 04:47:39PM +0900, AKASHI Takahiro wrote:
> With the patch below applied, host_block_dev structure was switched
> to be placed in platdata rather than priv. The command "host info"
> must be aligned with this change. Otherwise, we will see "Segmentation
> Fault."
>
> Fixes: 8f994c860d91 ("sandbox: blk: Switch to use platdata_auto_alloc_size for the driver data")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Tested-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191006/411e10fd/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-06 22:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-22 7:47 [U-Boot] [PATCH] cmd: host: fix seg fault at "host info" AKASHI Takahiro
2019-08-27 1:12 ` Bin Meng
2019-08-27 2:54 ` Heinrich Schuchardt
2019-10-03 6:04 ` AKASHI Takahiro
2019-10-03 7:27 ` Bin Meng
2019-10-06 22:03 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox