public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Patrick Wildt <patrick@blueri.se>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node
Date: Fri, 4 Oct 2019 17:50:07 +0200	[thread overview]
Message-ID: <20191004155007.GA410@jump> (raw)
In-Reply-To: <CAOMZO5A_srTWs-h2zo8+h2ysiBKwnCnyHC_6khjaHKOttWi3pA@mail.gmail.com>

On Fri, Oct 04, 2019 at 09:39:29AM -0300, Fabio Estevam wrote:
> Hi Patrick,
> 
> On Thu, Oct 3, 2019 at 11:12 AM Patrick Wildt <patrick@blueri.se> wrote:
> >
> > This patch adds the reset controller node to the i.MX8MQ SoC
> > device tree.
> >
> > Signed-off-by: Patrick Wildt <patrick@blueri.se>
> > ---
> >  arch/arm/dts/fsl-imx8mq.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/dts/fsl-imx8mq.dtsi b/arch/arm/dts/fsl-imx8mq.dtsi
> > index c35c23e293..d843b401be 100644
> > --- a/arch/arm/dts/fsl-imx8mq.dtsi
> > +++ b/arch/arm/dts/fsl-imx8mq.dtsi
> > @@ -19,6 +19,7 @@
> >  #include <dt-bindings/input/input.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/pinctrl/pins-imx8mq.h>
> > +#include <dt-bindings/reset/imx8mq-reset.h>
> >  #include <dt-bindings/thermal/thermal.h>
> >
> >  / {
> > @@ -269,6 +270,12 @@
> >                 #clock-cells = <1>;
> >         };
> >
> > +       src: reset-controller at 30390000 {
> > +               compatible = "fsl,imx8mq-src", "syscon";
> > +               reg = <0x0 0x30390000 0x0 0x10000>;
> > +               #reset-cells = <1>;
> 
> This reset-controller node is already part of the upstream kernel imx8mq.dtsi.
> 
> What about syncing the U-Boot version with the one from kernel 5.3.2?
> Also, please note the dtsi name change.
> 
> Thanks

Hi Fabio,

yes, that's true.  It does make sense to sync the device trees and
do the name change.  Can the diff with the reset controller driver
(patch 1/3) be merged anyway, and I'll follow up with the DTS change?
Would be easier for me to handle the number of patches to submit.

Thank you for the review!

Best regards,
Patrick

> 
> > +       };
> > +
> >         gpc: gpc at 303a0000 {
> >                 compatible = "fsl,imx8mq-gpc", "fsl,imx7d-gpc", "syscon";
> >                 reg = <0x0 0x303a0000 0x0 0x10000>;
> > --
> > 2.23.0
> >

  reply	other threads:[~2019-10-04 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30 14:59 [U-Boot] [PATCH] imx: add support for i.MX7/i.MX8MQ reset controller Patrick Wildt
2019-10-03 13:50 ` Patrick Wildt
2019-10-03 14:01   ` Fabio Estevam
2019-10-03 14:08     ` [U-Boot] [PATCH 1/3] " Patrick Wildt
2019-10-04 12:36       ` Fabio Estevam
2019-10-03 14:12     ` [U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node Patrick Wildt
2019-10-04 12:39       ` Fabio Estevam
2019-10-04 15:50         ` Patrick Wildt [this message]
2019-10-04 15:52           ` Fabio Estevam
2019-10-05 16:34             ` Stefano Babic
2019-10-03 14:13     ` [U-Boot] [PATCH 3/3] imx: enable the reset controller on the i.MX8MQ EVK Patrick Wildt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191004155007.GA410@jump \
    --to=patrick@blueri.se \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox