From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick Wildt <patrick@blueri.se>
Date: Fri, 4 Oct 2019 17:50:07 +0200
Subject: [U-Boot] [PATCH 2/3] imx: add the i.MX8M reset controller node
In-Reply-To: <CAOMZO5A_srTWs-h2zo8+h2ysiBKwnCnyHC_6khjaHKOttWi3pA@mail.gmail.com>
References: <20190930145928.GA29381@ryzen.blueri.se>
 <20191003135009.GC50411@nox.fritz.box>
 <CAOMZO5AdbWztWBba2fwmbw9oqBRpRoT2ipTk-N-NOvhxrwKWLg@mail.gmail.com>
 <20191003141257.GB50476@nox.fritz.box>
 <CAOMZO5A_srTWs-h2zo8+h2ysiBKwnCnyHC_6khjaHKOttWi3pA@mail.gmail.com>
Message-ID: <20191004155007.GA410@jump>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Oct 04, 2019 at 09:39:29AM -0300, Fabio Estevam wrote:
> Hi Patrick,
> 
> On Thu, Oct 3, 2019 at 11:12 AM Patrick Wildt <patrick@blueri.se> wrote:
> >
> > This patch adds the reset controller node to the i.MX8MQ SoC
> > device tree.
> >
> > Signed-off-by: Patrick Wildt <patrick@blueri.se>
> > ---
> >  arch/arm/dts/fsl-imx8mq.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/dts/fsl-imx8mq.dtsi b/arch/arm/dts/fsl-imx8mq.dtsi
> > index c35c23e293..d843b401be 100644
> > --- a/arch/arm/dts/fsl-imx8mq.dtsi
> > +++ b/arch/arm/dts/fsl-imx8mq.dtsi
> > @@ -19,6 +19,7 @@
> >  #include <dt-bindings/input/input.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/pinctrl/pins-imx8mq.h>
> > +#include <dt-bindings/reset/imx8mq-reset.h>
> >  #include <dt-bindings/thermal/thermal.h>
> >
> >  / {
> > @@ -269,6 +270,12 @@
> >                 #clock-cells = <1>;
> >         };
> >
> > +       src: reset-controller at 30390000 {
> > +               compatible = "fsl,imx8mq-src", "syscon";
> > +               reg = <0x0 0x30390000 0x0 0x10000>;
> > +               #reset-cells = <1>;
> 
> This reset-controller node is already part of the upstream kernel imx8mq.dtsi.
> 
> What about syncing the U-Boot version with the one from kernel 5.3.2?
> Also, please note the dtsi name change.
> 
> Thanks

Hi Fabio,

yes, that's true.  It does make sense to sync the device trees and
do the name change.  Can the diff with the reset controller driver
(patch 1/3) be merged anyway, and I'll follow up with the DTS change?
Would be easier for me to handle the number of patches to submit.

Thank you for the review!

Best regards,
Patrick

> 
> > +       };
> > +
> >         gpc: gpc at 303a0000 {
> >                 compatible = "fsl,imx8mq-gpc", "fsl,imx7d-gpc", "syscon";
> >                 reg = <0x0 0x303a0000 0x0 0x10000>;
> > --
> > 2.23.0
> >