public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/3] env: Add CONFIG_ENV_FULL_SUPPORT
Date: Tue, 08 Oct 2019 13:09:53 +0200	[thread overview]
Message-ID: <20191008110953.573CD240044@gemini.denx.de> (raw)
In-Reply-To: <20191007223650.GR6716@bill-the-cat>

Dear Tom,

In message <20191007223650.GR6716@bill-the-cat> you wrote:
> 
> > Do I understand correctly that all of this is obsolete and no longer
> > needed after Tom's commit d90fc9c3de ``Revert "env: solve
> > compilation error in SPL"'' ?
>
> So, I think there's a new topic here.  I seem to recall a concern from
> the previous thread that we could have less restrictive environment
> protections in SPL/TPL than we do in full U-Boot and thus open ourselves
> to a potential problem.  As of today, U-Boot is back to where it was
> prior to the problematic patch being applied.  But do we not have the
> potential problem above and thus need to evaluate the rest of the
> series (as the revert was largely the same as the first patch in the
> series) ?  Thanks!

The (potential) problem of having less restrictive/secure code in
SPL than in U-Boot proper resulted from the fact that the patch
series allowed different configurations of the U-Boot environment
features in these stages.

After the revert of the original problem, I don't see the need for
any such configuration, so if we simply do nothing we are as secure
as we have been before.

When accepting this new patch series, a full review of the impacts
(size, security) is needed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In an infinite universe all things are possible, including the possi-
bility that the universe does not exist.
                        - Terry Pratchett, _The Dark Side of the Sun_

  reply	other threads:[~2019-10-08 11:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03  7:24 [U-Boot] [PATCH v4 0/3] env: Add CONFIG_ENV_FULL_SUPPORT Patrick Delaunay
2019-10-03  7:24 ` [U-Boot] [PATCH v4 1/3] env: correct the check of env_flags_validate presence Patrick Delaunay
2019-10-03 13:18   ` Tom Rini
2019-10-03  7:24 ` [U-Boot] [PATCH v4 2/3] env: introduce macro ENV_IS_IN_SOMEWHERE Patrick Delaunay
2020-03-18 16:03   ` Patrick DELAUNAY
2019-10-03  7:24 ` [U-Boot] [PATCH v4 3/3] env: Add CONFIG_ENV_FULL_SUPPORT Patrick Delaunay
2020-03-18 16:06   ` Patrick DELAUNAY
2019-10-07 17:56 ` [U-Boot] [PATCH v4 0/3] " Wolfgang Denk
2019-10-07 22:36   ` Tom Rini
2019-10-08 11:09     ` Wolfgang Denk [this message]
2019-10-14 14:46   ` Patrick DELAUNAY
2019-10-15  9:28     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008110953.573CD240044@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox