[U-Boot] [PATCH v1] Makefile: Skip symbolic links to files for cscope

[U-Boot] [PATCH v1] Makefile: Skip symbolic links to files for cscope

[Andy Shevchenko]

cscope complains that it can't find files that appears to be symbolic links

cscope: cannot find file tools/binman/test/u_boot_binman_syms_bad.c
cscope: cannot find file tools/version.h

`find -L` tests properties, but name, and cscope can't cope with symbolic
links (a lot of bugs in upstream were simple closed as kinda invalid).

To work around the problem, exclude symbolic links from the cscope.files.
Note, it's done in two pass to speed up the process (`-exec realpath ...`
approach is not portable and introduces a 3x delay).

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index 54da5cd51c..968a70885b 100644
--- a/Makefile
+++ b/Makefile
@@ -1793,6 +1793,9 @@ etags:
 cscope:
 		$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) -name '*.[chS]' -print > \
 						cscope.files
+		@find $(TAG_SUBDIRS) -name '*.[chS]' -type l -print | \
+			grep -xvf - cscope.files > cscope.files.no-symlinks; \
+		mv cscope.files.no-symlinks cscope.files
 		cscope -b -q -k
 
 SYSTEM_MAP = \
-- 
2.23.0

[U-Boot] [PATCH v1] Makefile: Skip symbolic links to files for cscope

[Tom Rini]

On Tue, Oct 08, 2019 at 09:12:45PM +0300, Andy Shevchenko wrote:

> cscope complains that it can't find files that appears to be symbolic links
> 
> cscope: cannot find file tools/binman/test/u_boot_binman_syms_bad.c
> cscope: cannot find file tools/version.h
> 
> `find -L` tests properties, but name, and cscope can't cope with symbolic
> links (a lot of bugs in upstream were simple closed as kinda invalid).
> 
> To work around the problem, exclude symbolic links from the cscope.files.
> Note, it's done in two pass to speed up the process (`-exec realpath ...`
> approach is not portable and introduces a 3x delay).
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191017/bdf23c08/attachment.sig>