* [U-Boot] [PATCH] spl: Introduce SPL_DM_SPI Kconfig define
@ 2019-09-09 10:06 Lukasz Majewski
2019-10-09 9:01 ` Lukasz Majewski
2019-10-12 20:23 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Lukasz Majewski @ 2019-09-09 10:06 UTC (permalink / raw)
To: u-boot
This define indicates if DM_SPI shall be supported in SPL. This allows
proper operation of DM converted SPI drivers in SPL, which use
#if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS converted
boards.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
Applied on top of -master branch:
SHA1: 448f11f7503995746a7b71e5e3b3a831c4651be9
This patch is a first step for converting SPI #defines to Kconfig.
It was a part of "CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*" patch:
https://patchwork.ozlabs.org/patch/1158141/
which in spite of not introducing the apparent build breaks, was
responsible for some deltas in SPL and U-Boot proper sizes (some parts of
SPI code was not compiled in). To fix those board/SoC access to real HW is
necessary as well as deep understanding of SPL SPI requirements.
---
common/spl/Kconfig | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index 7c3391cabe..183ecf6264 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -683,6 +683,13 @@ config SPL_UBI
Enable support for loading payloads from UBI. See
README.ubispl for more info.
+if SPL_DM
+config SPL_DM_SPI
+ bool "Support SPI DM drivers in SPL"
+ help
+ Enable support for SPI DM drivers in SPL.
+
+endif
if SPL_UBI
config SPL_UBI_LOAD_BY_VOLNAME
bool "Support loading volumes by name"
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] spl: Introduce SPL_DM_SPI Kconfig define
2019-09-09 10:06 [U-Boot] [PATCH] spl: Introduce SPL_DM_SPI Kconfig define Lukasz Majewski
@ 2019-10-09 9:01 ` Lukasz Majewski
2019-10-12 20:23 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Lukasz Majewski @ 2019-10-09 9:01 UTC (permalink / raw)
To: u-boot
Dear Tom,
> This define indicates if DM_SPI shall be supported in SPL. This allows
> proper operation of DM converted SPI drivers in SPL, which use
> #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS
> converted boards.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Tom, are there any issues preventing this patch from being applied to
-master?
>
> ---
>
> Applied on top of -master branch:
> SHA1: 448f11f7503995746a7b71e5e3b3a831c4651be9
>
> This patch is a first step for converting SPI #defines to Kconfig.
> It was a part of "CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*" patch:
> https://patchwork.ozlabs.org/patch/1158141/
>
> which in spite of not introducing the apparent build breaks, was
> responsible for some deltas in SPL and U-Boot proper sizes (some
> parts of SPI code was not compiled in). To fix those board/SoC access
> to real HW is necessary as well as deep understanding of SPL SPI
> requirements.
>
> ---
> common/spl/Kconfig | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 7c3391cabe..183ecf6264 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -683,6 +683,13 @@ config SPL_UBI
> Enable support for loading payloads from UBI. See
> README.ubispl for more info.
>
> +if SPL_DM
> +config SPL_DM_SPI
> + bool "Support SPI DM drivers in SPL"
> + help
> + Enable support for SPI DM drivers in SPL.
> +
> +endif
> if SPL_UBI
> config SPL_UBI_LOAD_BY_VOLNAME
> bool "Support loading volumes by name"
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191009/a643430c/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] spl: Introduce SPL_DM_SPI Kconfig define
2019-09-09 10:06 [U-Boot] [PATCH] spl: Introduce SPL_DM_SPI Kconfig define Lukasz Majewski
2019-10-09 9:01 ` Lukasz Majewski
@ 2019-10-12 20:23 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2019-10-12 20:23 UTC (permalink / raw)
To: u-boot
On Mon, Sep 09, 2019 at 12:06:46PM +0200, Lukasz Majewski wrote:
> This define indicates if DM_SPI shall be supported in SPL. This allows
> proper operation of DM converted SPI drivers in SPL, which use
> #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS converted
> boards.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191012/ce2a07d3/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-12 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-09 10:06 [U-Boot] [PATCH] spl: Introduce SPL_DM_SPI Kconfig define Lukasz Majewski
2019-10-09 9:01 ` Lukasz Majewski
2019-10-12 20:23 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox