public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Soeren Moch <smoch@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: eth-uclass: Remove warning about ROM MAC address
Date: Fri, 11 Oct 2019 01:00:48 +0200	[thread overview]
Message-ID: <20191010230048.10935-1-smoch@web.de> (raw)

Using a MAC address from ROM storage is the normal case for most
ethernet hardware. Why should we warn about this?

Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: u-boot at lists.denx.de
---
 net/eth-uclass.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index 3bd98b01ad..8b29de37bb 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -538,8 +538,6 @@ static int eth_post_probe(struct udevice *dev)
 		memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN);
 	} else if (is_valid_ethaddr(pdata->enetaddr)) {
 		eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr);
-		printf("\nWarning: %s using MAC address from ROM\n",
-		       dev->name);
 	} else if (is_zero_ethaddr(pdata->enetaddr) ||
 		   !is_valid_ethaddr(pdata->enetaddr)) {
 #ifdef CONFIG_NET_RANDOM_ETHADDR
--
2.17.1

             reply	other threads:[~2019-10-10 23:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 23:00 Soeren Moch [this message]
2019-10-11  3:06 ` [U-Boot] [PATCH] net: eth-uclass: Remove warning about ROM MAC address Joe Hershberger
2019-10-11  8:07   ` Soeren Moch
2019-12-10  9:47   ` Fabio Estevam
2019-12-10  9:42 ` Fabio Estevam
2019-12-11 11:54 ` Schrempf Frieder
2020-01-06 23:32   ` Fabio Estevam
2020-01-28 16:33     ` Fabio Estevam
2020-02-09 17:26       ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191010230048.10935-1-smoch@web.de \
    --to=smoch@web.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox