From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] spl: ymodem: Fix FIT loading termination handling
Date: Sat, 12 Oct 2019 16:23:43 -0400 [thread overview]
Message-ID: <20191012202343.GG16029@bill-the-cat> (raw)
In-Reply-To: <20190815205532.16545-2-dannenberg@ti.com>
On Thu, Aug 15, 2019 at 03:55:26PM -0500, Andreas Dannenberg wrote:
> During FIT reading through ymodem_read_fit() the function
> xyzModem_stream_read() is being used which returns zero once the end
> of a stream has been reached. This could lead to an premature exit from
> ymodem_read_fit() with certain-sized FIT images reporting that zero
> bytes overall were read. Such a premature exit would then result in an
> -EIO failure being triggered within the spl_load_simple_fit() caller
> function and ultimately lead to a boot failure.
>
> Fix this logic by simply aborting the stream read loops and continuing
> with the regular code flow which ultimately would lead to returning
> the number of bytes to be read ('size') as expected by the callers of
> ymodem_read_fit().
>
> Fixes: fa715193c083 ("spl: Add an option to load a FIT containing U-Boot from UART")
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191012/afa8ff42/attachment.sig>
next prev parent reply other threads:[~2019-10-12 20:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 20:55 [U-Boot] [PATCH 0/7] Implement UART-based boot of TI K3 AM65x SoCs Andreas Dannenberg
2019-08-15 20:55 ` [U-Boot] [PATCH 1/7] spl: ymodem: Fix FIT loading termination handling Andreas Dannenberg
2019-10-12 20:23 ` Tom Rini [this message]
2019-08-15 20:55 ` [U-Boot] [PATCH 2/7] spl: ymodem: Make SPL Y-Modem loader framework accessible Andreas Dannenberg
2019-10-12 20:23 ` Tom Rini
2019-08-15 20:55 ` [U-Boot] [PATCH 3/7] arm: K3: common: Allow for early console functionality Andreas Dannenberg
2019-10-12 20:23 ` Tom Rini
2019-08-15 20:55 ` [U-Boot] [PATCH 4/7] arm: K3: sysfw-loader: Allow loading SYSFW via Y-Modem Andreas Dannenberg
2019-10-12 20:23 ` Tom Rini
2019-08-15 20:55 ` [U-Boot] [PATCH 5/7] armv7R: dts: k3: am654: Add MCU_UART0 related definitions Andreas Dannenberg
2019-10-12 20:24 ` Tom Rini
2019-08-15 20:55 ` [U-Boot] [PATCH 6/7] configs: am65x_evm_r5: Activate early console functionality Andreas Dannenberg
2019-10-12 20:24 ` Tom Rini
2019-08-15 20:55 ` [U-Boot] [PATCH 7/7] board: ti: am65x: Add UART boot procedure in README Andreas Dannenberg
2019-10-12 20:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012202343.GG16029@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox