From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 14 Oct 2019 14:41:30 +0200 Subject: [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define In-Reply-To: References: <20190929155441.24324-1-lukma@denx.de> <20191009110237.1683a068@jawa> Message-ID: <20191014144130.5283560d@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, > Hi Lukasz, > > On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski wrote: > > > > Dear Tom, > > > > > This define indicates if DM_GPIO shall be supported in SPL. This > > > allows proper operation of DM converted GPIO drivers in SPL, > > > which use boards. > > > > > > Signed-off-by: Lukasz Majewski > > > --- > > > > > > Changes in v2: > > > - Add dependency on DM_GPIO > > > > > > > Tom, are there any issues preventing this patch from being applied > > to -master? > > This does not actually define DM_GPIO anywhere though, so this is > unused. The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter if you perform the changes from [1]. This Kconfig define is necessary for the XEA board (i.MX28 based one), which uses OF_PLATDATA in SPL excessively to fit into size constraints. To be more precise the mxs_gpio.c driver uses #if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with OF_PLATDATA. > > As it happens I sent a similar patch[1], but it doesn't work. I'll > try again. It would be great if we could have [1] not causing build breaks. However, for my used case it would be enough to have the Kconfig definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it. Simon, if you don't have time to do the fix for [1] I would opt for pulling this patch (to just add proper Kconfig define). > > > > > > common/spl/Kconfig | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > > > index f467eca2be..e3df8efa7e 100644 > > > --- a/common/spl/Kconfig > > > +++ b/common/spl/Kconfig > > > @@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT > > > the CPU moving the data. Enable this option to build the > > > drivers in drivers/dma as part of an SPL build. > > > > > > +config SPL_DM_GPIO > > > + bool "Support Driver Model GPIO drivers" > > > + depends on SPL_GPIO_SUPPORT && DM_GPIO > > > + help > > > + Enable support for Driver Model based GPIO drivers in SPL. > > > + > > > config SPL_DRIVERS_MISC_SUPPORT > > > bool "Support misc drivers" > > > help > > > > Regards, > SImon > > [1] http://patchwork.ozlabs.org/patch/1167276/ Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: