From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 00/11] import x509/pkcs7 parsers from linux
Date: Tue, 15 Oct 2019 17:56:41 +0900 [thread overview]
Message-ID: <20191015085640.GL18778@linaro.org> (raw)
In-Reply-To: <8f301c7e-1bbc-a45f-9f43-ab107db291f4@gmx.de>
On Tue, Oct 15, 2019 at 07:33:18AM +0200, Heinrich Schuchardt wrote:
> On 10/15/19 5:18 AM, AKASHI Takahiro wrote:
> >On Sat, Oct 12, 2019 at 03:02:09PM +0200, Heinrich Schuchardt wrote:
> >>On 10/11/19 9:55 AM, AKASHI Takahiro wrote:
> >>>I hope this patch set will be reviewed promptly as I'm aiming to
> >>>push my "UEFI secure boot" patch for v2020.01.
> >>>
> >>
> >>How can I make all of these new files being built to check for build
> >>warnings?
> >
> >As always in my case of UEFI secure boot, they have gone through build and
> >run/tests as part of UEFI secure boot. This is also true for RSA
> >extension as UEFI secure boot is the only user of those features.
>
> Did you run them through Travis?
>
> >
> >Please note that almost of all the code here come from the latest
> >linux code without any changes. A few changes that I made are
> >quite U-Boot/UEFI-secure-boot specific and is *best* tested through
> >UEFI secure boot test.
> >
> >That said, you can at least build the code by enabling
> > Library routines
> > Security support
> > Asymmetric Key Support
> > CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE
> > CONFIG_X509_CERTIFICATE_PARSER
> > CONFIG_PKCS7_MESSAGE_PARSER
> >
> >>Please, provide unit tests for the patch series.
> >
> >As I said above, it will be exercised and tested under UEFI secure boot
> >test.
>
> If there is nothing I can test now, I would not know how to evaluate
> these patches.
Do you ask me to write "unit tests" to test all the aspects of
asn1 compiler and parsers that I have not developed any part of
and that are not changed from the original?
Doesn't make sense.
> There is good reason that we have unit tests and don't simply say U-Boot
> can be tested by booting Linux.
There are lots of examples, one is the original RSA routines, as I said,
which have not direct-linked tests and are only tested by vboot.py.
> >
> >>Please, provide a documentation how these different tools and files work
> >>together.
> >
> >What do you mean by different tools?
> >Asn1 compiler and what?
> >Do you want to have doc/README.asn1compiler?
>
> This patch series provides some puzzle pieces but doesn't tell me how
> they fit together. Maybe a README describing the different elements
> provided for UEFI secure boot would be most appropriate.
All what you need to know is that the patch set will generate
and provide x509 parser and pkcs7 parser as a result of build process.
I will a few lines of README.asn1compiler to describe that.
-Takahiro Akashi
> Best regards
>
> Heinrich
>
> >
> >Thanks,
> >-Takahiro Akashi
> >
> >
> >>Best regards
> >>
> >>Heinrich
> >
>
next prev parent reply other threads:[~2019-10-15 8:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 7:41 [U-Boot] [PATCH v1 00/11] import x509/pkcs7 parsers from linux AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 01/11] linux_compat: add kmemdup() AKASHI Takahiro
2019-10-12 11:22 ` Heinrich Schuchardt
2019-10-17 3:04 ` AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 02/11] include: time.h: define time64_t AKASHI Takahiro
2019-10-12 11:40 ` Heinrich Schuchardt
2019-10-17 5:39 ` AKASHI Takahiro
2019-10-17 5:51 ` Heinrich Schuchardt
2019-10-11 7:41 ` [U-Boot] [PATCH v1 03/11] include: kernel.h: include printk.h AKASHI Takahiro
2019-10-12 11:47 ` Heinrich Schuchardt
2019-10-17 5:58 ` AKASHI Takahiro
2019-10-17 6:17 ` AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 04/11] cmd: add asn1_compiler AKASHI Takahiro
2019-10-12 12:22 ` Heinrich Schuchardt
2019-10-17 6:25 ` AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 05/11] Makefile: add build script for asn1 parsers AKASHI Takahiro
2019-10-12 12:36 ` Heinrich Schuchardt
2019-10-17 6:40 ` AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 06/11] lib: add asn1 decoder AKASHI Takahiro
2019-10-12 12:29 ` Heinrich Schuchardt
2019-10-17 7:02 ` AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 07/11] lib: add oid registry utility AKASHI Takahiro
2019-10-12 12:58 ` Heinrich Schuchardt
2019-10-11 7:41 ` [U-Boot] [PATCH v1 08/11] lib: crypto: add public key utility AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 09/11] lib: crypto: add x509 parser AKASHI Takahiro
2019-10-11 7:41 ` [U-Boot] [PATCH v1 10/11] lib: crypto: add pkcs7 message parser AKASHI Takahiro
2019-10-11 7:42 ` [U-Boot] [PATCH v1 11/11] lib: crypto: add rsa public key parser AKASHI Takahiro
2019-10-12 13:11 ` Heinrich Schuchardt
2019-10-11 7:55 ` [U-Boot] [PATCH v1 00/11] import x509/pkcs7 parsers from linux AKASHI Takahiro
2019-10-12 13:02 ` Heinrich Schuchardt
2019-10-15 3:18 ` AKASHI Takahiro
2019-10-15 5:33 ` Heinrich Schuchardt
2019-10-15 8:56 ` AKASHI Takahiro [this message]
2019-10-15 11:10 ` Heinrich Schuchardt
2019-10-15 9:25 ` AKASHI Takahiro
2019-10-17 15:23 ` Tom Rini
2019-10-18 8:36 ` AKASHI Takahiro
2019-10-18 12:35 ` Tom Rini
2019-10-23 6:43 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015085640.GL18778@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox