From mboxrd@z Thu Jan  1 00:00:00 1970
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
Date: Fri, 18 Oct 2019 17:36:28 +0900
Subject: [U-Boot] [PATCH v1 00/11] import x509/pkcs7 parsers from linux
In-Reply-To: <20191017152321.GM16029@bill-the-cat>
References: <20191011074200.30269-1-takahiro.akashi@linaro.org>
 <20191011075507.GF18778@linaro.org>
 <2cee5152-3dea-5592-b7e5-590c95ece109@gmx.de>
 <20191015031819.GH18778@linaro.org>
 <8f301c7e-1bbc-a45f-9f43-ab107db291f4@gmx.de>
 <20191015092518.GN18778@linaro.org>
 <20191017152321.GM16029@bill-the-cat>
Message-ID: <20191018083626.GX18778@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,

On Thu, Oct 17, 2019 at 11:23:21AM -0400, Tom Rini wrote:
> On Tue, Oct 15, 2019 at 06:25:19PM +0900, AKASHI Takahiro wrote:
> > On Tue, Oct 15, 2019 at 07:33:18AM +0200, Heinrich Schuchardt wrote:
> > > On 10/15/19 5:18 AM, AKASHI Takahiro wrote:
> > > >On Sat, Oct 12, 2019 at 03:02:09PM +0200, Heinrich Schuchardt wrote:
> > > >>On 10/11/19 9:55 AM, AKASHI Takahiro wrote:
> > > >>>I hope this patch set will be reviewed promptly as I'm aiming to
> > > >>>push my "UEFI secure boot" patch for v2020.01.
> > > >>>
> > > >>
> > > >>How can I make all of these new files being built to check for build
> > > >>warnings?
> > > >
> > > >As always in my case of UEFI secure boot, they have gone through build and
> > > >run/tests as part of UEFI secure boot. This is also true for RSA
> > > >extension as UEFI secure boot is the only user of those features.
> > > 
> > > Did you run them through Travis?
> > 
> > As far as this patch set is concerned, no configuration enables
> > any of kconfig options listed below and running Travis doesn't make sense.
> 
> That's a problem that needs to be fixed.  I am not OK with the idea of
> adding a new feature that will not be put through our CI and so when
> things break it (which will happen, inadvertently) it won't be caught
> until much later.  Figuring out how to extend our CI to test this is a
> must.  Thanks!

I added a simple *unit* test under "test/lib."
As I said before, however, no existing configuration enables either
   CONFIG_X509_CERTIFICATE_PARSER, nor
   CONFIG_PKCS7_MESSAGE_PARSER

and the related code won't be built or exercised in any way.
So I made a small trick to Kconfig:

=== 8< ===
config UT_LIB
        bool "Unit tests for library functions"
        depends on UNIT_TEST
        default y
        help
          Enables the 'ut lib' command which tests library functions like
          memcat(), memcyp(), memmove().

if UT_LIB

config UT_LIB_ASN1
        bool "Unit test for asn1 compiler and decoder function"
        default y
        imply ASYMMETRIC_KEY_TYPE
        imply ASYMMETRIC_PUBLIC_KEY_SUBTYPE
        imply X509_CERTIFICATE_PARSER
        imply PKCS7_MESSAGE_PARSER
        imply RSA_PUBLIC_KEY_PARSER
        help
          Enables a test which exercises asn1 compiler and decoder function
          via various parsers.

endif
=== >8 ===

So as long as UT_LIB is enabled and run by one of Travis CI test cases,
a new test for ASN1 will also be exercised.
(I don't know which one will invoke "ut" command.)

Do you agree to this approach?

Thanks,
-Takahiro Akashi

> -- 
> Tom