* [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option
@ 2019-10-18 18:29 Patrick Delaunay
2019-10-18 20:25 ` Lukasz Majewski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Patrick Delaunay @ 2019-10-18 18:29 UTC (permalink / raw)
To: u-boot
Correct the name of the define used in CONFIG_IS_ENABLED():
it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.
This correct a regression introduced by
commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE
option")
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
drivers/pinctrl/pinctrl-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c
index 0b1eb7fab4..dc2340b779 100644
--- a/drivers/pinctrl/pinctrl-uclass.c
+++ b/drivers/pinctrl/pinctrl-uclass.c
@@ -157,7 +157,7 @@ static int pinconfig_post_bind(struct udevice *dev)
UCLASS_DRIVER(pinconfig) = {
.id = UCLASS_PINCONFIG,
-#if CONFIG_IS_ENABLED(PINCONFIG_RECURSIVE)
+#if CONFIG_IS_ENABLED(PINCONF_RECURSIVE)
.post_bind = pinconfig_post_bind,
#endif
.name = "pinconfig",
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option
2019-10-18 18:29 [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option Patrick Delaunay
@ 2019-10-18 20:25 ` Lukasz Majewski
2019-10-19 19:56 ` Anatolij Gustschin
2019-10-19 20:02 ` Anatolij Gustschin
2 siblings, 0 replies; 6+ messages in thread
From: Lukasz Majewski @ 2019-10-18 20:25 UTC (permalink / raw)
To: u-boot
On Fri, 18 Oct 2019 20:29:22 +0200
Patrick Delaunay <patrick.delaunay@st.com> wrote:
> Correct the name of the define used in CONFIG_IS_ENABLED():
> it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.
>
> This correct a regression introduced by
> commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE
> option")
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
> drivers/pinctrl/pinctrl-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-uclass.c
> b/drivers/pinctrl/pinctrl-uclass.c index 0b1eb7fab4..dc2340b779 100644
> --- a/drivers/pinctrl/pinctrl-uclass.c
> +++ b/drivers/pinctrl/pinctrl-uclass.c
> @@ -157,7 +157,7 @@ static int pinconfig_post_bind(struct udevice
> *dev)
> UCLASS_DRIVER(pinconfig) = {
> .id = UCLASS_PINCONFIG,
> -#if CONFIG_IS_ENABLED(PINCONFIG_RECURSIVE)
> +#if CONFIG_IS_ENABLED(PINCONF_RECURSIVE)
> .post_bind = pinconfig_post_bind,
> #endif
> .name = "pinconfig",
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191018/823560ad/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option
2019-10-18 18:29 [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option Patrick Delaunay
2019-10-18 20:25 ` Lukasz Majewski
@ 2019-10-19 19:56 ` Anatolij Gustschin
2019-10-19 20:02 ` Anatolij Gustschin
2 siblings, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2019-10-19 19:56 UTC (permalink / raw)
To: u-boot
On Fri, 18 Oct 2019 20:29:22 +0200
Patrick Delaunay patrick.delaunay at st.com wrote:
> Correct the name of the define used in CONFIG_IS_ENABLED():
> it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.
>
> This correct a regression introduced by
> commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE
> option")
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Anatolij Gustschin <agust@denx.de>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option
2019-10-18 18:29 [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option Patrick Delaunay
2019-10-18 20:25 ` Lukasz Majewski
2019-10-19 19:56 ` Anatolij Gustschin
@ 2019-10-19 20:02 ` Anatolij Gustschin
2019-10-21 17:10 ` Patrick DELAUNAY
2 siblings, 1 reply; 6+ messages in thread
From: Anatolij Gustschin @ 2019-10-19 20:02 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Fri, 18 Oct 2019 20:29:22 +0200
Patrick Delaunay patrick.delaunay at st.com wrote:
...
> This correct a regression introduced by
> commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE
> option")
Could you please apply this patch ASAP? It fixes broken eMMC, Ethernet,
I2C, GPIO, etc. on i.MX8QXP MEK board.
Many other boards are affected, too.
Thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option
2019-10-19 20:02 ` Anatolij Gustschin
@ 2019-10-21 17:10 ` Patrick DELAUNAY
2019-10-21 18:09 ` Anatolij Gustschin
0 siblings, 1 reply; 6+ messages in thread
From: Patrick DELAUNAY @ 2019-10-21 17:10 UTC (permalink / raw)
To: u-boot
Hi Anatolij and Tom,
> From: Anatolij Gustschin <agust@denx.de>
> Sent: samedi 19 octobre 2019 22:02
>
> Hi Tom,
>
> On Fri, 18 Oct 2019 20:29:22 +0200
> Patrick Delaunay patrick.delaunay at st.com wrote:
> ...
> > This correct a regression introduced by commit c20851b3d850 ("dm:
> > pinctrl: introduce PINCONF_RECURSIVE
> > option")
>
> Could you please apply this patch ASAP? It fixes broken eMMC, Ethernet, I2C,
> GPIO, etc. on i.MX8QXP MEK board.
>
> Many other boards are affected, too.
>
> Thanks!
I check deeper today the root cause of the issue and I have a clean solution
with v2 patch: http://patchwork.ozlabs.org/patch/1180575/
The friday patch wasn't enough at least for my board, but ok for sandbox.
And a minor correction of the Kconfig (not blocking)
http://patchwork.ozlabs.org/patch/1180576/
> --
> Anatolij
Sorry for disturbance.
Patrick
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-21 18:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-18 18:29 [U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option Patrick Delaunay
2019-10-18 20:25 ` Lukasz Majewski
2019-10-19 19:56 ` Anatolij Gustschin
2019-10-19 20:02 ` Anatolij Gustschin
2019-10-21 17:10 ` Patrick DELAUNAY
2019-10-21 18:09 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox