From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Wiklander Date: Wed, 23 Oct 2019 08:46:13 +0200 Subject: [U-Boot] [PATCH v2 3/4] image: fdt: copy possible optee nodes to a loaded devicetree In-Reply-To: <20191022190428.14868-3-heiko@sntech.de> References: <20191022190428.14868-1-heiko@sntech.de> <20191022190428.14868-3-heiko@sntech.de> Message-ID: <20191023064612.GA29514@jax> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Oct 22, 2019 at 09:04:27PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > The loading convention for optee or any other tee on arm64 is as bl32 > parameter to the trusted-firmware. So TF-A gets invoked with the TEE as > bl32 and main u-boot as bl33. Once it has done its startup TF-A jumps > into the bl32 for the TEE startup, returns to TF-A and then jumps to bl33. > > All of them get passed a devicetree as parameter and all components often > get loaded from a FIT image. > > OP-TEE will create additional nodes in that devicetree namely a firmware > node and possibly multiple reserved-memory nodes. > > While this devicetree is used in main u-boot, in most cases it won't be > the one passed to the actual kernel. Instead most boot commands will load > a new devicetree from somewhere like mass storage of the network, so if > that happens u-boot should transfer the optee nodes to that new devicetree. > > To make that happen introduce optee_copy_fdt_nodes() called from the dt > setup function in image-fdt which after checking for the optee presence > in the u-boot dt will make sure a optee node is present in the kernel dt > and transfer any reserved-memory regions it can find. > > Signed-off-by: Heiko Stuebner > --- > changes in v2: > - don't create a new optee firmware-node, but instead copy the > compatible+method properties from the old fdt blob. > > common/image-fdt.c | 8 +++ > include/tee/optee.h | 9 +++ > lib/optee/optee.c | 132 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 149 insertions(+) > [snip] Looks good to me: Reviewed-by: Jens Wiklander Cheers, Jens