[U-Boot] [PATCH v5 24/26] cmd: nand/sf: isolate legacy code

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 24/26] cmd: nand/sf: isolate legacy code
Date: Fri, 25 Oct 2019 11:25:07 +0200	[thread overview]
Message-ID: <20191025112508.18f9e820@xps13> (raw)
In-Reply-To: <CAMty3ZAvCfRxHvcxgJU4ap5PN-YXjYZqozor2bU1Y3z3GkdSnw@mail.gmail.com>

Hi Jagan,

Jagan Teki <jagan@amarulasolutions.com> wrote on Fri, 25 Oct 2019
14:44:38 +0530:

> On Thu, Oct 3, 2019 at 11:21 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > The 'sf' command is not supposed to rely on the MTD stack, but both
> > 'sf' and 'nand' commands use helpers located in mtd_uboot.c. Despite
> > their location, these functions do not depend at all on the MTD
> > stack.
> >
> > This file (drivers/mtd/mtd_uboot.c) is only compiled if CONFIG_MTD is
> > selected, which is inconsistent with the current situation. Solve this
> > by moving these three functions (which are only used by the above two
> > commands) out of mtd_uboot.c and put them in a C file only compiled
> > with cmd/sf.c and cmd/nand.c.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  cmd/Makefile            |  3 ++
> >  cmd/legacy-mtd-utils.c  | 99 +++++++++++++++++++++++++++++++++++++++++
> >  cmd/legacy-mtd-utils.h  | 14 ++++++
> >  cmd/nand.c              |  2 +
> >  cmd/sf.c                |  2 +
> >  drivers/mtd/mtd_uboot.c | 94 --------------------------------------  
> 
> Better to drop CMD_SF, CMD_NAND in makefile so-that it can't build
> this file in this patch.

I don't understand what you mean. Can you please detail what you have
in mind for this patch?

Is it something blocking for you? Or is it something that should be
taken care of after?

Thanks,
MiquÃ¨l

next prev parent reply	other threads:[~2019-10-25  9:25 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 17:50 [U-Boot] [PATCH v5 00/26]MTD defconfigs/Kconfigs/Makefiles heavy cleanup Miquel Raynal
2019-10-03 17:50 ` [U-Boot] [PATCH v5 01/26] mtd: rename CONFIG_NAND -> CONFIG_MTD_RAW_NAND Miquel Raynal
2019-12-05  2:50   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 02/26] mtd: rename CONFIG_MTD -> CONFIG_DM_MTD Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 03/26] mtd: rename CONFIG_MTD_DEVICE -> CONFIG_MTD Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 04/26] mtd: ensure MTD is compiled when there is a NOR flash Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 05/26] mtd: ensure MTD/the raw NAND core are compiled when there is a NAND flash Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 06/26] mtd: ensure MTD is compiled when there is a SPI NOR flash using MTD Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 07/26] mtd: ensure UBI is compiled when using fastmap Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 08/26] mtd: ensure MTD is compiled when UBI is used Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 09/26] mtd: ensure UBI is compiled when CMD_UBI is selected Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 10/26] mtd: ensure UBI is compiled when ENV_IS_IN_UBI " Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 11/26] mtd: ensure MTD_RAW_NAND is compiled when ENV_IS_IN_NAND " Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 12/26] mtd: ensure CMD_NAND is compiled when its options are selected Miquel Raynal
2019-12-05  2:51   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 13/26] mtd: ensure MTD is compiled when CMD_MTDPARTS is selected Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 14/26] configs: move CONFIG_MTD in defconfigs when set in arch includes Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 15/26] configs: remove raw NAND core from k2g defconfigs Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 16/26] configs: remove MTD support from bcm11130 and M54418TWR defconfigs Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 17/26] configs: socfpga: mcvevk: Remove useless UBI infos Miquel Raynal
2019-11-24 15:13   ` Tom Rini
2019-11-25 11:53     ` Wolfgang Grandegger
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 18/26] configs: ls104x/ls108x/ls208x: Build the raw NAND core with TFABOOT Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 19/26] mtd: nand: add includes in NAND core to avoid warnings Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 20/26] dfu: add dependency on the raw NAND core Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 21/26] mtd: nor: NOR flashes depend on MTD Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 22/26] mtd: spi: SPI_FLASH_MTD depends " Miquel Raynal
2019-12-05  2:52   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 23/26] cmd: mtdparts: Kconfig: join mtdparts command entry with its options Miquel Raynal
2019-12-05  2:53   ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 24/26] cmd: nand/sf: isolate legacy code Miquel Raynal
2019-10-25  9:14   ` Jagan Teki
2019-10-25  9:25     ` Miquel Raynal [this message]
2019-10-25  9:27       ` Jagan Teki
2019-10-25  9:36         ` Miquel Raynal
2019-10-25  9:46           ` Jagan Teki
2019-10-25 17:38             ` Miquel Raynal
2019-10-03 17:50 ` [U-Boot] [PATCH v5 25/26] cmd: make MTD commands depend on MTD Miquel Raynal
2019-10-03 17:50 ` [U-Boot] [PATCH v5 26/26] mtd: Makefile: deep cleanup Miquel Raynal
2019-10-03 17:55 ` [U-Boot] [PATCH v5 00/26]MTD defconfigs/Kconfigs/Makefiles heavy cleanup Miquel Raynal
2019-10-21  8:08   ` Miquel Raynal
2019-10-21  8:12     ` Jagan Teki
2019-10-23 11:58       ` Tom Rini
2019-10-23 19:09         ` Jagan Teki
2019-10-25  9:21 ` Jagan Teki
2019-10-30 13:57 ` Tom Rini
2019-10-31 15:05   ` Miquel Raynal
2019-12-05  2:50 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025112508.18f9e820@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox