[U-Boot] [PATCH v2 16/17] test: add lib specific Kconfig

[Tom Rini <trini@konsulko.com>]

On Fri, Oct 25, 2019 at 07:07:48PM +0900, AKASHI Takahiro wrote:
> Adding new unit tests for library routines will make test/Kconfig
> messy. So just create a Kconfig file under lib.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  test/Kconfig     | 8 +-------
>  test/lib/Kconfig | 7 +++++++
>  2 files changed, 8 insertions(+), 7 deletions(-)
>  create mode 100644 test/lib/Kconfig
> 
> diff --git a/test/Kconfig b/test/Kconfig
> index 48a0e501f88f..3a5aabedd0ef 100644
> --- a/test/Kconfig
> +++ b/test/Kconfig
> @@ -6,13 +6,7 @@ menuconfig UNIT_TEST
>  	  This does not require sandbox to be included, but it is most
>  	  often used there.
>  
> -config UT_LIB
> -	bool "Unit tests for library functions"
> -	depends on UNIT_TEST
> -	default y
> -	help
> -	  Enables the 'ut lib' command which tests library functions like
> -	  memcat(), memcyp(), memmove().
> +source "test/lib/Kconfig"
>  
>  config UT_TIME
>  	bool "Unit tests for time functions"
> diff --git a/test/lib/Kconfig b/test/lib/Kconfig
> new file mode 100644
> index 000000000000..a983bdcaa3f1
> --- /dev/null
> +++ b/test/lib/Kconfig
> @@ -0,0 +1,7 @@
> +config UT_LIB
> +	bool "Unit tests for library functions"
> +	depends on UNIT_TEST
> +	default y
> +	help
> +	  Enables the 'ut lib' command which tests library functions like
> +	  memcat(), memcyp(), memmove().

But we then only add one more entry in the next patch.  How many library
tests do you see adding when everything is done?  If it's less than 5,
we should just keep things in the test/Kconfig file I think.  The rest
of the series seems fine, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191025/6ee79e81/attachment.sig>