From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Pull request: u-boot-spi/master
Date: Fri, 25 Oct 2019 13:48:58 -0400 [thread overview]
Message-ID: <20191025174858.GF11173@bill-the-cat> (raw)
In-Reply-To: <20191025083812.28256-1-jagan@amarulasolutions.com>
On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:
> Hi Tom,
>
> Please pull this PR.
>
> Summary:
> - SPL_SPI_FLASH_MTD (Frieder)
> - SPI NOR IDs' fixes, additions (Vignesh)
> - cs_info change (Bin)
> - Enable sunxi spi (Jagan)
>
> Travis-CI:
> https://travis-ci.org/openedev/u-boot-amarula/builds/602483415
>
> Thanks,
> Jagan.
>
> The following changes since commit 17fd9915a4c639381804ed28274fa136ae3b0bee:
>
> Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)
>
> are available in the Git repository at:
>
> https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
>
> for you to fetch changes up to 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:
>
> spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 +0530)
>
So, looking over the build output, I see the expected size increase in
sunxi due to new support. But I also see a lot of size increases in
rockchip and layerscape platforms (and possibly more, I stopped after
spotting two different SoCs), for example:
evb-px5 : all +12139 data +176 rodata +2275 spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata +309 spl/u-boot-spl:text +3100 text +9688
u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
function old new delta
spi_nor_scan - 2032 +2032
do_spi_flash - 2008 +2008
spi_get_bus_and_cs - 436 +436
spi_mem_exec_op - 420 +420
static.spi_nor_wait_till_ready_with_timeout - 300 +300
spi_nor_write - 300 +300
mtd_arg_off_size - 276 +276
spi_nor_erase - 232 +232
device_unbind - 232 +232
spi_nor_read_data - 220 +220
spi_nor_write_data - 212 +212
dm_spi_claim_bus - 196 +196
spi_mem_adjust_op_size - 160 +160
spi_mem_default_supports_op - 156 +156
spi_nor_read - 152 +152
spi_flash_probe_bus_cs - 152 +152
spi_set_speed_mode - 148 +148
spi_flash_std_erase - 136 +136
spi_flash_std_probe - 132 +132
mtd_arg_off - 124 +124
device_chld_unbind - 120 +120
_u_boot_list_2_driver_2_spi_flash_std - 120 +120
spi_nor_write_reg - 104 +104
spi_find_bus_and_cs - 104 +104
spi_nor_read_reg - 100 +100
spi_find_chip_select - 96 +96
static.spi_check_buswidth_req - 88 +88
str2off - 80 +80
bytes_per_second - 76 +76
spi_flash_std_write - 72 +72
spi_flash_std_read - 72 +72
spi_mem_supports_op - 56 +56
_u_boot_list_2_cmd_2_sf - 56 +56
dm_spi_xfer - 48 +48
read_sr - 44 +44
device_find_next_child - 40 +40
spi_flash_cmd_get_sw_write_prot - 36 +36
dm_spi_release_bus - 28 +28
write_enable - 20 +20
write_disable - 20 +20
spi_flash_std_get_sw_write_prot - 20 +20
spi_flash_write_dm - 16 +16
spi_flash_read_dm - 16 +16
spi_flash_erase_dm - 16 +16
spi_xfer - 8 +8
spi_release_bus - 8 +8
spi_flash_std_remove - 8 +8
spi_claim_bus - 8 +8
flash - 8 +8
spl-u-boot-spl: add: 25/0, grow: 0/0 bytes: 3220/0 (3220)
function old new delta
spi_nor_scan - 904 +904
spi_mem_exec_op - 420 +420
spi_nor_read - 304 +304
dm_spi_claim_bus - 196 +196
spi_mem_adjust_op_size - 160 +160
spi_mem_default_supports_op - 156 +156
spi_set_speed_mode - 148 +148
spi_flash_std_erase - 136 +136
spi_flash_std_probe - 132 +132
_u_boot_list_2_driver_2_spi_flash_std - 120 +120
spi_nor_write_reg - 104 +104
static.spi_check_buswidth_req - 88 +88
spi_flash_std_write - 72 +72
spi_flash_std_read - 72 +72
spi_mem_supports_op - 56 +56
dm_spi_xfer - 48 +48
dm_spi_release_bus - 28 +28
spi_flash_std_get_sw_write_prot - 20 +20
spi_xfer - 8 +8
spi_release_bus - 8 +8
spi_nor_write - 8 +8
spi_nor_erase - 8 +8
spi_flash_std_remove - 8 +8
spi_flash_cmd_get_sw_write_prot - 8 +8
spi_claim_bus - 8 +8
ls2088aqds_tfa : all +12906 data +120 rodata +2982 text +9804
u-boot: add: 44/0, grow: 0/0 bytes: 8460/0 (8460)
function old new delta
spi_nor_scan - 2168 +2168
sst26_lock_ctl - 604 +604
stm_unlock - 536 +536
stm_lock - 536 +536
sst_write - 504 +504
spi_mem_exec_op - 420 +420
spi_nor_write - 300 +300
spi_nor_wait_till_ready - 300 +300
spi_nor_erase - 232 +232
spi_nor_read_data - 220 +220
spi_nor_write_data - 212 +212
dm_spi_claim_bus - 196 +196
spi_mem_adjust_op_size - 160 +160
spi_mem_default_supports_op - 156 +156
spi_nor_read - 152 +152
spi_flash_std_erase - 136 +136
spi_flash_std_probe - 132 +132
stm_is_locked - 120 +120
_u_boot_list_2_driver_2_spi_flash_std - 120 +120
static.write_sr_and_check - 112 +112
spi_nor_write_reg - 104 +104
spi_nor_read_reg - 100 +100
stm_is_unlocked_sr - 92 +92
stm_is_locked_sr - 92 +92
static.spi_check_buswidth_req - 88 +88
sst26_process_bpr - 88 +88
stm_get_locked_range - 80 +80
spi_flash_std_write - 72 +72
spi_flash_std_read - 72 +72
spi_mem_supports_op - 56 +56
dm_spi_xfer - 48 +48
read_sr - 44 +44
sst26_is_locked - 36 +36
spi_flash_cmd_get_sw_write_prot - 36 +36
dm_spi_release_bus - 28 +28
write_enable - 20 +20
write_disable - 20 +20
spi_flash_std_get_sw_write_prot - 20 +20
sst26_unlock - 8 +8
sst26_lock - 8 +8
spi_xfer - 8 +8
spi_release_bus - 8 +8
spi_flash_std_remove - 8 +8
spi_claim_bus - 8 +8
So this strongly feels like something is being enabled by default when
it shouldn't. You may want to use buildman with something like:
$ git checkout -b current-spi-changes origin/master
$ export SOURCE_DATE_EPOCH=`date +%s`
$ ./tools/buildman/buildman -o /tmp/ls2088aqds_tfa -b current-spi-changes \
-SBCdevlk ls2088aqds_tfa
$ ./tools/buildman/buildman -o /tmp/ls2088aqds_tfa -b current-spi-changes \
-SsBdevlk ls2088aqds_tfa
If nothing in the git log stands out to you as to which commit is
causing this growth. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191025/88cb77a7/attachment.sig>
next prev parent reply other threads:[~2019-10-25 17:48 UTC|newest]
Thread overview: 217+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 8:38 [U-Boot] Pull request: u-boot-spi/master Jagan Teki
2019-10-25 17:48 ` Tom Rini [this message]
2019-10-27 11:50 ` Jagan Teki
2019-10-28 0:46 ` Tom Rini
2019-10-31 7:53 ` Schrempf Frieder
2019-10-31 7:57 ` Jagan Teki
2019-10-31 8:01 ` Schrempf Frieder
2019-10-31 8:09 ` Jagan Teki
-- strict thread matches above, loose matches on Subject: below --
2019-09-16 2:45 Jagan Teki
2019-09-17 23:55 ` Tom Rini
2019-07-18 11:48 Jagan Teki
2019-06-17 7:45 Jagan Teki
2019-06-18 17:00 ` Tom Rini
2019-05-20 17:18 Jagan Teki
2019-05-21 11:12 ` Tom Rini
2019-05-24 19:34 ` Jagan Teki
2019-06-07 7:51 ` Mario Six
2019-06-07 8:56 ` Heiko Schocher
2019-06-07 9:10 ` Mario Six
2019-06-07 9:15 ` Heiko Schocher
2019-06-07 9:33 ` Mario Six
2019-05-05 16:42 Jagan Teki
2019-05-07 2:43 ` Tom Rini
2019-04-17 12:21 Jagan Teki
2019-04-17 12:45 ` Vignesh Raghavendra
2019-04-18 16:20 ` Tom Rini
2019-04-12 13:43 Jagan Teki
2019-04-14 12:57 ` Tom Rini
2019-03-06 17:02 Jagan Teki
2019-03-07 14:14 ` Tom Rini
2019-02-07 19:47 Jagan Teki
2019-02-08 3:13 ` Tom Rini
2019-01-02 19:19 Jagan Teki
2019-01-03 19:54 ` Jagan Teki
2019-01-03 20:34 ` Tom Rini
2018-12-23 21:19 Jagan Teki
2018-12-23 21:56 ` Jagan Teki
2018-12-24 1:01 ` Tom Rini
2018-12-05 19:23 Jagan Teki
2018-12-06 1:32 ` Tom Rini
2018-10-12 6:15 Jagan Teki
2018-10-15 12:41 ` Tom Rini
2018-10-04 13:16 Jagan Teki
2018-10-05 14:16 ` Tom Rini
2018-10-02 16:56 Jagan Teki
2018-10-03 0:54 ` Tom Rini
2018-10-03 6:42 ` Miquel Raynal
2018-08-04 16:13 Jagan Teki
2018-08-05 11:59 ` Tom Rini
2018-07-16 13:01 Jagan Teki
2018-07-17 1:11 ` Tom Rini
2018-07-02 17:35 Jagan Teki
2018-07-03 3:24 ` Tom Rini
2018-06-25 18:49 Jagan Teki
2018-06-25 21:35 ` Tom Rini
2018-06-27 6:47 ` Jagan Teki
2018-06-27 15:20 ` Tom Rini
2018-06-27 15:34 ` Jagan Teki
2018-06-28 18:17 ` Tom Rini
2018-06-05 18:28 Jagan Teki
2018-06-06 15:09 ` Tom Rini
2018-05-30 18:08 Jagan Teki
2018-05-31 2:10 ` Tom Rini
2018-04-25 5:29 Jagan Teki
2018-04-26 11:21 ` Tom Rini
2018-03-24 8:25 Jagan Teki
2018-03-26 19:09 ` Tom Rini
2018-03-14 14:02 Jagan Teki
2018-03-14 17:27 ` Tom Rini
2018-03-14 17:39 ` Jagan Teki
2018-03-14 18:38 ` Adam Ford
2018-03-14 18:47 ` Jagan Teki
2018-03-15 14:10 ` Jagan Teki
2018-01-22 5:50 Jagan Teki
2018-01-22 12:58 ` Tom Rini
2018-01-22 14:56 ` Daniel Schwierzeck
2018-01-22 14:59 ` Tom Rini
2018-01-22 15:28 ` Daniel Schwierzeck
2018-01-22 15:32 ` Tom Rini
2018-01-22 15:47 ` Daniel Schwierzeck
2018-01-22 16:49 ` Daniel Schwierzeck
2018-01-22 17:14 ` Tom Rini
2018-01-22 20:26 ` Daniel Schwierzeck
2018-01-22 20:55 ` Álvaro Fernández Rojas
2018-01-22 21:05 ` Tom Rini
2018-01-23 10:28 ` Daniel Schwierzeck
2018-01-24 6:57 ` Jagan Teki
2018-01-25 16:00 ` Álvaro Fernández Rojas
2017-12-19 12:24 Jagan Teki
2017-12-19 20:44 ` Tom Rini
2017-10-17 13:50 Jagan Teki
2017-10-18 19:47 ` Tom Rini
2017-09-25 7:51 Jagan Teki
2017-09-25 8:41 ` Łukasz Majewski
2017-09-25 8:57 ` Jagan Teki
2017-09-26 12:17 ` Tom Rini
2017-08-16 13:00 Jagan Teki
2017-08-17 1:17 ` Tom Rini
2017-05-03 12:13 Jagan Teki
2017-05-07 1:27 ` Tom Rini
2017-01-15 17:32 Jagan Teki
2017-01-16 4:02 ` Tom Rini
2017-01-04 16:33 Jagan Teki
2017-01-05 13:28 ` Tom Rini
2016-12-23 23:39 Jagan Teki
2016-12-23 23:43 ` Tom Rini
2016-12-14 15:36 Jagan Teki
2016-12-14 23:35 ` Tom Rini
2016-11-18 11:16 Jagan Teki
2016-11-19 0:57 ` Tom Rini
2016-11-20 11:59 ` Jagan Teki
2016-11-22 17:21 ` Tom Rini
2016-11-12 12:13 Jagan Teki
2016-11-13 20:55 ` Tom Rini
2016-09-22 15:02 Jagan Teki
2016-09-23 1:57 ` Tom Rini
2016-08-09 12:03 Jagan Teki
2016-08-09 13:27 ` Tom Rini
2016-07-29 18:48 Jagan Teki
2016-07-30 0:20 ` Tom Rini
2016-07-09 15:30 Jagan Teki
2016-07-09 16:06 ` Tom Rini
2016-07-12 17:59 ` Tom Rini
2016-03-15 7:11 Jagan Teki
2016-03-15 12:01 ` Tom Rini
2016-03-15 15:04 ` Tom Rini
2016-03-15 17:51 ` Jagan Teki
2016-03-12 14:44 Jagan Teki
2016-03-13 13:45 ` Tom Rini
2016-02-23 10:49 Jagan Teki
2016-02-23 20:35 ` Tom Rini
2016-02-25 17:13 ` Mugunthan V N
2016-03-01 5:46 ` Mugunthan V N
2016-01-13 14:46 Jagan Teki
2016-01-13 21:54 ` Tom Rini
2016-01-07 17:02 Jagan Teki
2016-01-07 17:42 ` Tom Rini
2015-12-11 16:53 Jagan Teki
2015-12-12 1:13 ` Tom Rini
2015-11-19 17:46 Jagan Teki
2015-11-19 22:07 ` Tom Rini
2015-10-28 18:22 Jagan Teki
2015-10-28 18:25 ` Otavio Salvador
2015-10-28 18:31 ` Jagan Teki
2015-10-29 1:42 ` Tom Rini
2015-10-25 8:04 Jagan Teki
2015-08-18 6:38 Jagan Teki
2015-08-18 14:47 ` Tom Rini
2015-07-04 8:41 Jagan Teki
2015-07-04 11:42 ` Tom Rini
2015-07-07 15:26 ` Jagan Teki
2015-07-14 22:12 ` Tom Rini
2015-07-01 17:33 Jagan Teki
2015-07-01 21:56 ` Tom Rini
2015-06-29 19:24 Jagan Teki
2015-06-29 21:51 ` Tom Rini
2015-06-23 15:17 Jagan Teki
2015-06-24 23:31 ` Tom Rini
2015-06-25 3:58 ` Heiko Schocher denx
2015-06-25 5:31 ` Jagan Teki
2015-06-25 11:36 ` Tom Rini
2015-06-25 13:26 ` Jagan Teki
2015-04-28 8:17 Jagannadha Sutradharudu Teki
2015-04-28 14:51 ` Tom Rini
2015-03-31 7:14 Jagannadha Sutradharudu Teki
2015-04-07 17:58 ` Tom Rini
2015-01-08 18:40 Jagannadha Sutradharudu Teki
2015-01-09 13:34 ` Tom Rini
2015-01-01 20:45 Jagannadha Sutradharudu Teki
2015-01-05 15:10 ` Tom Rini
2014-12-29 17:07 Jagannadha Sutradharudu Teki
2015-01-05 15:10 ` Tom Rini
2014-10-27 18:43 Jagannadha Sutradharudu Teki
2014-11-04 2:32 ` Tom Rini
2014-09-24 12:45 Jagannadha Sutradharudu Teki
2014-09-25 14:43 ` Tom Rini
2014-08-05 18:52 Jagannadha Sutradharudu Teki
2014-08-06 14:37 ` Tom Rini
2014-06-08 17:57 Jagannadha Sutradharudu Teki
2014-06-11 19:09 ` Tom Rini
2014-03-17 16:42 Jagannadha Sutradharudu Teki
2014-03-17 21:19 ` Tom Rini
2014-02-18 17:24 Jagannadha Sutradharudu Teki
2014-02-21 14:35 ` Tom Rini
2014-01-27 17:26 Jagannadha Sutradharudu Teki
2014-01-27 19:21 ` Marek Vasut
2014-01-22 16:26 Jagannadha Sutradharudu Teki
2014-01-24 20:10 ` Marek Vasut
2014-01-20 17:53 Jagannadha Sutradharudu Teki
2014-01-20 19:37 ` Marek Vasut
2014-01-20 19:47 ` Jagan Teki
2014-01-13 18:35 Jagannadha Sutradharudu Teki
2014-01-13 19:42 ` Tom Rini
2014-01-15 19:38 ` Marek Vasut
2014-01-16 6:06 ` Jagan Teki
2014-01-16 19:04 ` Marek Vasut
2014-01-16 19:44 ` Jagan Teki
2014-01-18 20:26 ` Marek Vasut
2013-12-19 18:22 Jagannadha Sutradharudu Teki
2013-12-19 22:15 ` Tom Rini
2013-10-15 18:58 Jagannadha Sutradharudu Teki
2013-10-15 21:25 ` Tom Rini
2013-10-07 14:22 Jagannadha Sutradharudu Teki
2013-10-08 19:32 ` Tom Rini
2013-09-15 17:19 Jagannadha Sutradharudu Teki
2013-09-17 0:09 ` Tom Rini
2013-08-10 12:26 Jagannadha Sutradharudu Teki
2013-08-12 16:00 ` Tom Rini
2013-06-23 17:59 Jagannadha Sutradharudu Teki
2013-06-25 14:56 ` Tom Rini
2013-06-13 18:50 Jagannadha Sutradharudu Teki
2013-06-14 14:36 ` Tom Rini
2013-06-14 14:45 ` Jagan Teki
2013-06-14 14:51 ` Tom Rini
2013-06-14 14:53 ` Tom Rini
2013-06-14 15:00 ` Jagan Teki
2013-06-14 15:11 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025174858.GF11173@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox