From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support
Date: Sun, 27 Oct 2019 01:15:09 +0200 [thread overview]
Message-ID: <20191027011509.7ffa2f0b@crub> (raw)
In-Reply-To: <CANr=Z=bVFDQZjLdJMss0stTLdLsmSGGxGkH2exvqOUjU9WGMCw@mail.gmail.com>
Hi Joe,
On Tue, 3 Sep 2019 22:00:08 +0000
Joe Hershberger joe.hershberger at ni.com wrote:
> On Mon, Jul 29, 2019 at 6:17 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
> >
> > On Thu, Jul 25, 2019 at 4:42 PM Anatolij Gustschin <agust@denx.de> wrote:
> > >
> > > On Tue, 23 Jul 2019 04:26:17 +0000
> > > Joe Hershberger joe.hershberger at ni.com wrote:
> > > ...
> > > > > +config MV88E61XX_88E6020_FAMILY
> > > > > + bool "Marvell MV88E6020 family support."
> > > > > + help
> > > > > + The driver supports 6172/6176/6240/6352 devices in the
> > > > > + default configuration. Select this option to enable support
> > > > > + for 6250/6220/6020/6070/6071 switches.
> > > >
> > > > Is there a rhyme or reason to the model numbers here? This option
> > > > seems oddly named, especially since the help doesn't have the model
> > > > numbers in numerical order. Can you make it a choice instead?
> > >
> > > We want to be able to use single U-Boot images which support different
> > > switches, a choice will make it not possible.
> >
> > I don't see how choice is any different than what you have here in
> > that respect. You have a hard-coded selection among families. If you
> > have a need to run the same binary on multiple switches, then this
> > option should be removed and the pre-init should be detecting the
> > target.
>
> Any response here?
Sorry for delay, I've been too busy with other stuff. v4 patch series
was reworked to drop this config option. Thanks!
--
Anatolij
next prev parent reply other threads:[~2019-10-26 23:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 23:22 [U-Boot] [PATCH v2 0/6] Extend mv88e61xx driver to support 88E6071 Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices Anatolij Gustschin
2019-07-23 4:00 ` Joe Hershberger
2019-07-23 4:07 ` Joe Hershberger
2019-07-26 14:48 ` Anatolij Gustschin
2019-07-26 18:51 ` Joe Hershberger
2019-07-25 21:40 ` Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 2/6] net: phy: mv88e61xx: add CPU port parameter init for 88E6071 Anatolij Gustschin
2019-07-23 4:05 ` Joe Hershberger
2019-07-25 21:40 ` Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 3/6] net: phy: mv88E61xx: fix ENERGY_DET init for mv88E6071 Anatolij Gustschin
2019-07-23 4:11 ` Joe Hershberger
2019-07-09 23:22 ` [U-Boot] [PATCH v2 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support Anatolij Gustschin
2019-07-23 4:26 ` Joe Hershberger
2019-07-25 21:41 ` Anatolij Gustschin
2019-07-29 23:18 ` Joe Hershberger
2019-09-03 22:00 ` Joe Hershberger
2019-10-26 23:15 ` Anatolij Gustschin [this message]
2019-07-09 23:22 ` [U-Boot] [PATCH v2 5/6] net: phy: mv88e61xx: register phy_driver struct for 88E6071 Anatolij Gustschin
2019-07-23 4:29 ` Joe Hershberger
2019-07-25 21:41 ` Anatolij Gustschin
2019-07-09 23:22 ` [U-Boot] [PATCH v2 6/6] net: phy: fix switch vendor name Anatolij Gustschin
2019-07-23 4:29 ` Joe Hershberger
2019-07-10 9:04 ` [U-Boot] [PATCH v2 0/6] Extend mv88e61xx driver to support 88E6071 Chris Packham
2019-07-10 9:14 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027011509.7ffa2f0b@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox