From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Sun, 27 Oct 2019 01:15:09 +0200 Subject: [U-Boot] [PATCH v2 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support In-Reply-To: References: <20190709232251.31746-1-agust@denx.de> <20190709232251.31746-5-agust@denx.de> <20190725234107.5c2fe1c8@crub> Message-ID: <20191027011509.7ffa2f0b@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Joe, On Tue, 3 Sep 2019 22:00:08 +0000 Joe Hershberger joe.hershberger at ni.com wrote: > On Mon, Jul 29, 2019 at 6:17 PM Joe Hershberger wrote: > > > > On Thu, Jul 25, 2019 at 4:42 PM Anatolij Gustschin wrote: > > > > > > On Tue, 23 Jul 2019 04:26:17 +0000 > > > Joe Hershberger joe.hershberger at ni.com wrote: > > > ... > > > > > +config MV88E61XX_88E6020_FAMILY > > > > > + bool "Marvell MV88E6020 family support." > > > > > + help > > > > > + The driver supports 6172/6176/6240/6352 devices in the > > > > > + default configuration. Select this option to enable support > > > > > + for 6250/6220/6020/6070/6071 switches. > > > > > > > > Is there a rhyme or reason to the model numbers here? This option > > > > seems oddly named, especially since the help doesn't have the model > > > > numbers in numerical order. Can you make it a choice instead? > > > > > > We want to be able to use single U-Boot images which support different > > > switches, a choice will make it not possible. > > > > I don't see how choice is any different than what you have here in > > that respect. You have a hard-coded selection among families. If you > > have a need to run the same binary on multiple switches, then this > > option should be removed and the pre-init should be detecting the > > target. > > Any response here? Sorry for delay, I've been too busy with other stuff. v4 patch series was reworked to drop this config option. Thanks! -- Anatolij