public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Suneel Garapati <suneelglinux@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 09/29] drivers: pci-uclass: add VF map_bar support for Enhanced Allocation
Date: Tue, 29 Oct 2019 14:08:01 -0700	[thread overview]
Message-ID: <20191029210821.1954-10-suneelglinux@gmail.com> (raw)
In-Reply-To: <20191029210821.1954-1-suneelglinux@gmail.com>

From: Suneel Garapati <sgarapati@marvell.com>

Makes dm_pci_map_bar API available for Virtual function PCI devices
based on SR-IOV capability which support Enhanced Allocation.

Signed-off-by: Suneel Garapati <sgarapati@marvell.com>
---
 drivers/pci/pci-uclass.c | 46 +++++++++++++++++++++++++++++++++++-----
 include/pci.h            |  3 +++
 2 files changed, 44 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index 3be49c7115..f9823231b1 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -1359,13 +1359,19 @@ pci_addr_t dm_pci_phys_to_bus(struct udevice *dev, phys_addr_t phys_addr,
 }
 
 static void *dm_pci_map_ea_bar(struct udevice *dev, int bar, int flags,
-			       int ea_off)
+			       int ea_off, struct pci_child_platdata *pdata)
 {
 	int ea_cnt, i, entry_size;
 	int bar_id = (bar - PCI_BASE_ADDRESS_0) >> 2;
 	u32 ea_entry;
 	phys_addr_t addr;
 
+	/* In case of Virtual Function devices, device is Physical function,
+	 * so pdata will point to required VF specific data.
+	 */
+	if (pdata->is_virtfn)
+		bar_id += PCI_EA_BEI_VF_BAR0;
+
 	/* EA capability structure header */
 	dm_pci_read_config32(dev, ea_off, &ea_entry);
 	ea_cnt = (ea_entry >> 16) & PCI_EA_NUM_ENT_MASK;
@@ -1388,6 +1394,26 @@ static void *dm_pci_map_ea_bar(struct udevice *dev, int bar, int flags,
 			addr |= ((u64)ea_entry) << 32;
 		}
 
+		/* In case of Virtual Function devices using BAR
+		 * base and size, add offset for VFn BAR(1, 2, 3...n)
+		 */
+		if (pdata->is_virtfn) {
+			size_t sz;
+
+			/* MaxOffset, 1st DW */
+			dm_pci_read_config32(dev, ea_off + 8, &ea_entry);
+			sz = ea_entry & PCI_EA_FIELD_MASK;
+			/* Fill up lower 2 bits */
+			sz |= (~PCI_EA_FIELD_MASK);
+			if (ea_entry & PCI_EA_IS_64) {
+				/* MaxOffset 2nd DW */
+				dm_pci_read_config32(dev, ea_off + 16,
+						     &ea_entry);
+				sz |= ((u64)ea_entry) << 32;
+			}
+			addr += (pdata->virtid - 1) * (sz + 1);
+		}
+
 		/* size ignored for now */
 		return map_physmem(addr, 0, flags);
 	}
@@ -1400,17 +1426,27 @@ void *dm_pci_map_bar(struct udevice *dev, int bar, int flags)
 	pci_addr_t pci_bus_addr;
 	u32 bar_response;
 	int ea_off;
+	struct udevice *udev = dev;
+	struct pci_child_platdata *pdata = dev_get_parent_platdata(dev);
+
+	/* In case of Virtual Function devices, use PF udevice
+	 * as EA capability is defined in Physical Function
+	 */
+	if (pdata->is_virtfn)
+		udev = pdata->pfdev;
 
 	/*
 	 * if the function supports Enhanced Allocation use that instead of
 	 * BARs
+	 * Incase of virtual functions, pdata will help read VF BEI
+	 * and EA entry size.
 	 */
-	ea_off = dm_pci_find_capability(dev, PCI_CAP_ID_EA);
+	ea_off = dm_pci_find_capability(udev, PCI_CAP_ID_EA);
 	if (ea_off)
-		return dm_pci_map_ea_bar(dev, bar, flags, ea_off);
+		return dm_pci_map_ea_bar(udev, bar, flags, ea_off, pdata);
 
 	/* read BAR address */
-	dm_pci_read_config32(dev, bar, &bar_response);
+	dm_pci_read_config32(udev, bar, &bar_response);
 	pci_bus_addr = (pci_addr_t)(bar_response & ~0xf);
 
 	/*
@@ -1419,7 +1455,7 @@ void *dm_pci_map_bar(struct udevice *dev, int bar, int flags)
 	 * linear mapping.  In the future, this could read the BAR size
 	 * and pass that as the size if needed.
 	 */
-	return dm_pci_bus_to_virt(dev, pci_bus_addr, flags, 0, MAP_NOCACHE);
+	return dm_pci_bus_to_virt(udev, pci_bus_addr, flags, 0, MAP_NOCACHE);
 }
 
 static int _dm_pci_find_next_capability(struct udevice *dev, u8 pos, int cap)
diff --git a/include/pci.h b/include/pci.h
index 1343d0e9fb..27819e86f5 100644
--- a/include/pci.h
+++ b/include/pci.h
@@ -465,6 +465,9 @@
 #define PCI_EA_FIRST_ENT	4	/* First EA Entry in List */
 #define  PCI_EA_ES		0x00000007 /* Entry Size */
 #define  PCI_EA_BEI		0x000000f0 /* BAR Equivalent Indicator */
+/* 9-14 map to VF BARs 0-5 respectively */
+#define  PCI_EA_BEI_VF_BAR0	9
+#define  PCI_EA_BEI_VF_BAR5	14
 /* Base, MaxOffset registers */
 /* bit 0 is reserved */
 #define  PCI_EA_IS_64		0x00000002	/* 64-bit field flag */
-- 
2.23.0

  parent reply	other threads:[~2019-10-29 21:08 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 21:07 [U-Boot] [RFC PATCH 00/29] arm: Introduce Marvell/Cavium OcteonTX Suneel Garapati
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 01/29] include: pci_ids: add vendor ID for Cavium Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 02/29] include: pci: Increase max pci region limit Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 03/29] fdtdec: add API to read pci bus-range property Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 04/29] drivers: pci-uclass: fix incorrect argument in map_sysmem Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 05/29] drivers: pci-uclass: make DT subnode parse optional Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 06/29] drivers: pci-uclass: add multi entry support for pci regions Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 07/29] drivers: pci-uclass: add support for Enhanced Allocation in Bridges Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 08/29] drivers: pci-uclass: add support for Single-Root I/O Virtualizaiton Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` Suneel Garapati [this message]
2019-11-20  3:00   ` [U-Boot] [RFC PATCH 09/29] drivers: pci-uclass: add VF map_bar support for Enhanced Allocation Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 10/29] drivers: pci-uclass: Add support for Alternate-RoutingID capability Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 11/29] include: arm: asm: io: add 64bit clrbits and setbits helpers Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 12/29] drivers: rtc: ds1337: add driver model support Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 13/29] arch: include: octeontx: add headers for OcteonTX Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-11-20  5:47     ` [U-Boot] [EXT] " Aaron Williams
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 14/29] arch: include: octeontx2: add headers for OcteonTX2 Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 15/29] drivers: ata: ahci: update max id if it is more than available ports Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 16/29] drivers: ata: ahci: fill upper 32bit buffer address in sg descriptor Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 17/29] drivers: ata: ahci: add BAR index quirk for OcteonTX Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 18/29] drivers: pci: add PCI controller driver " Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 19/29] drivers: gpio: add GPIO " Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 20/29] drivers: i2c: add I2C " Suneel Garapati
2019-11-20  3:00   ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 21/29] drivers: spi: add SPI " Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 22/29] drivers: mmc: remove static qualifier on mmc_power_init Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 23/29] drivers: mmc: add MMC controller driver for OcteonTX Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 24/29] drivers: mtd: nand: add NAND " Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 25/29] drivers: net: add NIC " Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 26/29] drivers: net: add NIC controller driver for OcteonTX2 Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 27/29] drivers: watchdog: add reset support for OcteonTX Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 28/29] octeontx: Add support for OcteonTX SoC platforms Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 29/29] octeontx2: Add support for OcteonTX2 " Suneel Garapati
2019-10-30 17:06 ` [U-Boot] [RFC PATCH 00/29] arm: Introduce Marvell/Cavium OcteonTX Tim Harvey
2019-10-31  0:04   ` [U-Boot] [EXT] " Aaron Williams
2019-10-31 19:12     ` Tim Harvey
2019-10-31 19:22       ` Chandrakala Chavva
2019-11-05  1:09       ` Aaron Williams
2019-11-05 16:07         ` Tim Harvey
2019-10-31 19:46   ` [U-Boot] " Suneel Garapati
2019-10-31 22:14     ` Tim Harvey
2019-10-31 22:40       ` Suneel Garapati
2019-11-01 16:07         ` Tim Harvey
2019-11-19 18:55 ` Tim Harvey
2019-11-20  3:00   ` Simon Glass
2019-11-20 20:41     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029210821.1954-10-suneelglinux@gmail.com \
    --to=suneelglinux@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox