From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 00/26]MTD defconfigs/Kconfigs/Makefiles heavy cleanup
Date: Thu, 31 Oct 2019 16:05:26 +0100 [thread overview]
Message-ID: <20191031160526.3ed48fcd@xps13> (raw)
In-Reply-To: <20191030135713.GZ11173@bill-the-cat>
Hi Tom,
Tom Rini <trini@konsulko.com> wrote on Wed, 30 Oct 2019 09:57:13 -0400:
> On Thu, Oct 03, 2019 at 07:50:02PM +0200, Miquel Raynal wrote:
>
> > Hello,
> >
> > A year ago, while working on SPI-NAND support in U-Boot, I discovered
> > when modifying Makefiles a confusing organization where:
> > * Sub-directories/files are compiled from the root Makefile
> > * Commands are at the root of everything
> >
> > First I sent a series to move Makefile entries in their respective
> > directories. Then, I decided to continue working on the clarification
> > of the Makefile hierarchy in MTD and I sent four iterations of this
> > series which did not got merge at that time. Anyway, I revived this
> > series by rebasing all my work and updating everything that needed an
> > update.
> >
> > Here are the main points of the re-organization:
> > * Rename CONFIG_MTD into CONFIG_DM_MTD to reserve CONFIG_MTD to what
> > is called today CONFIG_MTD_DEVICE.
> > * Fix build dependencies in defconfigs, like: "UBI and NAND depend on MTD".
> > * Fix the Kconfig files to reflect these dependencies (as defconfigs
> > have been updated, nothing should break).
> > * Simplify the Makefiles: compiling the drivers/mtd/nand/raw/
> > sub-directory should just depend on MTD being compiled and the NAND
> > core as well, there is absolutely no logic to make it depend on
> > CMD_NAND.
> >
> > The New green Travis CI build for the fifth version of this series is
> > there (yes, 53 iterations):
> >
> > Please note that the only red test fails because of timeout, not an
> > actual error (at least I could not spot it). It is possible that this
> > series will produce noticeable changes for the users. The only reason
> > for that is because their configuration file was wrong. I have done my
> > best to fix them one by one, but I am not omniscient.
>
> OK, so I want to grab this series, and I intend to do my best to do so.
> But the problem this exposes is just how complex the uses of CONFIG_NAND
> got and in turn symbol re-use, on PowerPC. This (+ v6) showed a few
> minor migration problems when I size compared, and those are easily
> fixed. What isn't so easily fixed is that it was also changing
> how/where the environment is found on some PowerPC boards. Fixing that
> in turn requires finally finishing off the migration of the main
> CONFIG_ENV_xxx symbols to Kconfig. I have this done outside of about 20
> boards. I'm going to get that finished up as soon as I can and posted,
> then make this series depend on that. Thanks again for doing the hard
> work here, we really need this particular migration and clean up!
>
I see the problem, well, thanks for grabbing it, please keep us
updated and do not hesitate if you need help.
Thanks,
Miquèl
next prev parent reply other threads:[~2019-10-31 15:05 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 17:50 [U-Boot] [PATCH v5 00/26]MTD defconfigs/Kconfigs/Makefiles heavy cleanup Miquel Raynal
2019-10-03 17:50 ` [U-Boot] [PATCH v5 01/26] mtd: rename CONFIG_NAND -> CONFIG_MTD_RAW_NAND Miquel Raynal
2019-12-05 2:50 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 02/26] mtd: rename CONFIG_MTD -> CONFIG_DM_MTD Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 03/26] mtd: rename CONFIG_MTD_DEVICE -> CONFIG_MTD Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 04/26] mtd: ensure MTD is compiled when there is a NOR flash Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 05/26] mtd: ensure MTD/the raw NAND core are compiled when there is a NAND flash Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 06/26] mtd: ensure MTD is compiled when there is a SPI NOR flash using MTD Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 07/26] mtd: ensure UBI is compiled when using fastmap Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 08/26] mtd: ensure MTD is compiled when UBI is used Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 09/26] mtd: ensure UBI is compiled when CMD_UBI is selected Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 10/26] mtd: ensure UBI is compiled when ENV_IS_IN_UBI " Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 11/26] mtd: ensure MTD_RAW_NAND is compiled when ENV_IS_IN_NAND " Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 12/26] mtd: ensure CMD_NAND is compiled when its options are selected Miquel Raynal
2019-12-05 2:51 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 13/26] mtd: ensure MTD is compiled when CMD_MTDPARTS is selected Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 14/26] configs: move CONFIG_MTD in defconfigs when set in arch includes Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 15/26] configs: remove raw NAND core from k2g defconfigs Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 16/26] configs: remove MTD support from bcm11130 and M54418TWR defconfigs Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 17/26] configs: socfpga: mcvevk: Remove useless UBI infos Miquel Raynal
2019-11-24 15:13 ` Tom Rini
2019-11-25 11:53 ` Wolfgang Grandegger
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 18/26] configs: ls104x/ls108x/ls208x: Build the raw NAND core with TFABOOT Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 19/26] mtd: nand: add includes in NAND core to avoid warnings Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 20/26] dfu: add dependency on the raw NAND core Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 21/26] mtd: nor: NOR flashes depend on MTD Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 22/26] mtd: spi: SPI_FLASH_MTD depends " Miquel Raynal
2019-12-05 2:52 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 23/26] cmd: mtdparts: Kconfig: join mtdparts command entry with its options Miquel Raynal
2019-12-05 2:53 ` Tom Rini
2019-10-03 17:50 ` [U-Boot] [PATCH v5 24/26] cmd: nand/sf: isolate legacy code Miquel Raynal
2019-10-25 9:14 ` Jagan Teki
2019-10-25 9:25 ` Miquel Raynal
2019-10-25 9:27 ` Jagan Teki
2019-10-25 9:36 ` Miquel Raynal
2019-10-25 9:46 ` Jagan Teki
2019-10-25 17:38 ` Miquel Raynal
2019-10-03 17:50 ` [U-Boot] [PATCH v5 25/26] cmd: make MTD commands depend on MTD Miquel Raynal
2019-10-03 17:50 ` [U-Boot] [PATCH v5 26/26] mtd: Makefile: deep cleanup Miquel Raynal
2019-10-03 17:55 ` [U-Boot] [PATCH v5 00/26]MTD defconfigs/Kconfigs/Makefiles heavy cleanup Miquel Raynal
2019-10-21 8:08 ` Miquel Raynal
2019-10-21 8:12 ` Jagan Teki
2019-10-23 11:58 ` Tom Rini
2019-10-23 19:09 ` Jagan Teki
2019-10-25 9:21 ` Jagan Teki
2019-10-30 13:57 ` Tom Rini
2019-10-31 15:05 ` Miquel Raynal [this message]
2019-12-05 2:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031160526.3ed48fcd@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox